Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ReactAndroid/src/main/jni/react/cxxcomponents via prefab #35619

Closed
wants to merge 2 commits into from

Conversation

cortinico
Copy link
Contributor

Summary:
Reference reactwg/react-native-releases#41 (reply in thread)
I'm exposing ReactAndroid/src/main/jni/react/cxxcomponents to be consumed via prefab.
It will be available to both: react_nativemodule_core and reactnativejni

Changelog:
[Internal] [Changed] - Expose ReactAndroid/src/main/jni/react/cxxcomponents via prefab

Differential Revision: D41965512

cortinico and others added 2 commits December 12, 2022 10:56
Summary:
Reference reactwg/react-native-releases#41 (reply in thread)
I'm exposing the headers inside `ReactCommon/cxxreact` to be access via the Prefab API.

Changelog:
[Internal] [Changed] - Expose ReactCommon/cxxreact headers via Prefab

Differential Revision: D41965511

fbshipit-source-id: 3275ea64d62f96aa9b2ea49175bca5c1eb026e37
Summary:
Reference reactwg/react-native-releases#41 (reply in thread)
I'm exposing `ReactAndroid/src/main/jni/react/cxxcomponents` to be consumed via prefab.
It will be available to both: `react_nativemodule_core` and `reactnativejni`

Changelog:
[Internal] [Changed] - Expose ReactAndroid/src/main/jni/react/cxxcomponents via prefab

Differential Revision: D41965512

fbshipit-source-id: afbeccec4b70de3f5296e0a81240ea9073ea8a6b
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 12, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41965512

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,776,630 -57
android hermes armeabi-v7a 7,096,414 -57
android hermes x86 8,251,531 -5
android hermes x86_64 8,108,901 -47
android jsc arm64-v8a 8,969,654 +0
android jsc armeabi-v7a 7,702,739 +0
android jsc x86 9,033,808 +0
android jsc x86_64 9,510,746 +0

Base commit: 0f089ea
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0f089ea
Branch: main

@pull-bot
Copy link

PR build artifact for c9f4790 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for c9f4790 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 13, 2022
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 822396d.

kelset pushed a commit that referenced this pull request Dec 13, 2022
Summary:
Pull Request resolved: #35619

Reference reactwg/react-native-releases#41 (reply in thread)
I'm exposing `ReactAndroid/src/main/jni/react/cxxcomponents` to be consumed via prefab.
It will be available to both: `react_nativemodule_core` and `reactnativejni`

Changelog:
[Internal] [Changed] - Expose ReactAndroid/src/main/jni/react/cxxcomponents via prefab

Reviewed By: cipolleschi

Differential Revision: D41965512

fbshipit-source-id: 3a5a7473267e2e161d9d7fb0e8dfa74593b47b6e
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…book#35619)

Summary:
Pull Request resolved: facebook#35619

Reference reactwg/react-native-releases#41 (reply in thread)
I'm exposing `ReactAndroid/src/main/jni/react/cxxcomponents` to be consumed via prefab.
It will be available to both: `react_nativemodule_core` and `reactnativejni`

Changelog:
[Internal] [Changed] - Expose ReactAndroid/src/main/jni/react/cxxcomponents via prefab

Reviewed By: cipolleschi

Differential Revision: D41965512

fbshipit-source-id: 3a5a7473267e2e161d9d7fb0e8dfa74593b47b6e
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants