Add support for Arrays in generator #37145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45321685 |
Base commit: 1cd0f57 |
|
This pull request was exported from Phabricator. Differential Revision: D45321685 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 2, 2023
Summary: Pull Request resolved: facebook#37145 This diff adds the generation of Array types in events. It supports the generation of Array of: - Boolean - Int32 - Float - Double - String - Objects - Array **Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native. I'll take a stab at it in a next diff. ## Changelog: [General][Added] - Generate events with arrays Differential Revision: D45321685 fbshipit-source-id: 2544ad151738fd4ba185b20fe17daa09b8d98d48
cipolleschi
force-pushed
the
export-D45321685
branch
from
9bd7361
to
6ffb63e
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 2, 2023
Summary: Pull Request resolved: facebook#37145 This diff adds the generation of Array types in events. It supports the generation of Array of: - Boolean - Int32 - Float - Double - String - Objects - Array **Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native. I'll take a stab at it in a next diff. ## Changelog: [General][Added] - Generate events with arrays Differential Revision: D45321685 fbshipit-source-id: 01f4d04c81acb26fe8447cf4732c3f72f9627585
cipolleschi
force-pushed
the
export-D45321685
branch
from
6ffb63e
to
104117b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45321685 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45321685 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: facebook#37145 This diff adds the generation of Array types in events. It supports the generation of Array of: - Boolean - Int32 - Float - Double - String - Objects - Array **Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native. I'll take a stab at it in a next diff. ## Changelog: [General][Added] - Generate events with arrays Differential Revision: D45321685 fbshipit-source-id: 63b19bb627d37bf4276cc9e69c84f63db2a35cfd
cipolleschi
force-pushed
the
export-D45321685
branch
from
104117b
to
c7ab6ca
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 4, 2023
Summary: Pull Request resolved: facebook#37145 This diff adds the generation of Array types in events. It supports the generation of Array of: - Boolean - Int32 - Float - Double - String - Objects - Array **Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native. I'll take a stab at it in a next diff. ## Changelog: [General][Added] - Generate events with arrays Reviewed By: cortinico Differential Revision: D45321685 fbshipit-source-id: e968e62c6f0c56accd64280201dfbc5ac7643501
|
This pull request was exported from Phabricator. Differential Revision: D45321685 |
cipolleschi
force-pushed
the
export-D45321685
branch
from
c7ab6ca
to
41db706
Compare
Summary: This diff introduce support to parse arrays in events. We support parsing Arrays of: - Boolean - Double - Float - Int32 - String Enums - String - Objects - Arrays ## Changelog: [General][Added] - Add generic support for Arrays in Events parsing Differential Revision: https://internalfb.com/D45268779 fbshipit-source-id: 0f1cddfba5274ae18c48f864afbb8ef9d6213131
Summary: Pull Request resolved: facebook#37145 This diff adds the generation of Array types in events. It supports the generation of Array of: - Boolean - Int32 - Float - Double - String - Objects - Array **Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native. I'll take a stab at it in a next diff. ## Changelog: [General][Added] - Generate events with arrays Reviewed By: cortinico Differential Revision: D45321685 fbshipit-source-id: 3e0435e4d17a45f3f02d7cc6b56af73e3609b56a
|
This pull request was exported from Phabricator. Differential Revision: D45321685 |
cipolleschi
force-pushed
the
export-D45321685
branch
from
41db706
to
8ed908a
Compare
|
This pull request has been merged in b422375. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37145 This diff adds the generation of Array types in events. It supports the generation of Array of: - Boolean - Int32 - Float - Double - String - Objects - Array **Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native. I'll take a stab at it in a next diff. ## Changelog: [General][Added] - Generate events with arrays Reviewed By: cortinico Differential Revision: D45321685 fbshipit-source-id: 34b05f5501b06714d1fabf1a51cb057af7027f00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds the generation of Array types in events.
It supports the generation of Array of:
Note: This is a first iteration. We could improve the generation further by leveraging the
Bridgingmodule within React Native.I'll take a stab at it in a next diff.
Changelog:
[General][Added] - Generate events with arrays
Differential Revision: D45321685