Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Arrays in generator #37145

Closed
wants to merge 2 commits into from

Commits on May 4, 2023

  1. Support Array parsing in events

    Summary:
    This diff introduce support to parse arrays in events.
    
    We support parsing Arrays of:
    - Boolean
    - Double
    - Float
    - Int32
    - String Enums
    - String
    - Objects
    - Arrays
    
    ## Changelog:
    [General][Added] - Add generic support for Arrays in Events parsing
    
    Differential Revision: https://internalfb.com/D45268779
    
    fbshipit-source-id: 0f1cddfba5274ae18c48f864afbb8ef9d6213131
    Riccardo Cipolleschi authored and facebook-github-bot committed May 4, 2023
    Configuration menu
    Copy the full SHA
    06cca9a View commit details
    Browse the repository at this point in the history
  2. Add support for Arrays in generator (facebook#37145)

    Summary:
    Pull Request resolved: facebook#37145
    
    This diff adds the generation of Array types in events.
    
    It supports the generation of Array of:
    - Boolean
    - Int32
    - Float
    - Double
    - String
    - Objects
    - Array
    
    **Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native.
    I'll take a stab at it in a next diff.
    
    ## Changelog:
    [General][Added] - Generate events with arrays
    
    Reviewed By: cortinico
    
    Differential Revision: D45321685
    
    fbshipit-source-id: 3e0435e4d17a45f3f02d7cc6b56af73e3609b56a
    cipolleschi authored and facebook-github-bot committed May 4, 2023
    Configuration menu
    Copy the full SHA
    8ed908a View commit details
    Browse the repository at this point in the history