Invalidate NSTextStorage on AttributedString change #38070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47019250 |
Base commit: e1fd4a8 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Jun 26, 2023
Summary: Pull Request resolved: facebook#38070 changelog: [iOS][fix]: Correctly invalidate NSTextStorage when non layout related props change Fixes: facebook#37944 Problem: NSTextStorage was not invalidated if non-layout props were changed. So for example 'color' dynamically changed, it wouldn't get invalidated and font of incorrect color would be rendered on screen. Reviewed By: javache Differential Revision: D47019250 fbshipit-source-id: ba33d542dad2eaa0c3effcf827ad03f37fb11cc0
sammy-SC
force-pushed
the
export-D47019250
branch
from
e2f42dc
to
f02cd90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47019250 |
Summary: Pull Request resolved: facebook#38070 changelog: [iOS][fix]: Correctly invalidate NSTextStorage when non layout related props change Fixes: facebook#37944 Problem: NSTextStorage was not invalidated if non-layout props were changed. So for example 'color' dynamically changed, it wouldn't get invalidated and font of incorrect color would be rendered on screen. Reviewed By: javache Differential Revision: D47019250 fbshipit-source-id: 7926253c627788673b2f008d83b15b5374339fbc
sammy-SC
force-pushed
the
export-D47019250
branch
from
f02cd90
to
7a951ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47019250 |
|
This pull request was successfully merged by @sammy-SC in 247da6e. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in 247da6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog:
[iOS][fix]: Correctly invalidate NSTextStorage when non layout related props change
Fixes: #37944
Problem:
NSTextStorage was not invalidated if non-layout props were changed. So for example 'color' dynamically changed, it wouldn't get invalidated and font of incorrect color would be rendered on screen.
Reviewed By: javache
Differential Revision: D47019250