Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate NSTextStorage on AttributedString change #38070

Closed
wants to merge 1 commit into from
Closed

Invalidate NSTextStorage on AttributedString change #38070

wants to merge 1 commit into from

Commits on Jun 26, 2023

  1. Invalidate NSTextStorage on AttributedString change (facebook#38070) 

    Summary:
Pull Request resolved: facebook#38070

changelog:
[iOS][fix]: Correctly invalidate NSTextStorage when non layout related props change

Fixes: facebook#37944

Problem:
NSTextStorage was not invalidated if non-layout props were changed. So for example 'color' dynamically changed, it wouldn't get invalidated and font of incorrect color would be rendered on screen.

Reviewed By: javache

Differential Revision: D47019250

fbshipit-source-id: 7926253c627788673b2f008d83b15b5374339fbc
    @sammy-SC @facebook-github-bot
    sammy-SC authored and facebook-github-bot committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    7a951ac View commit details
    Browse the repository at this point in the history