Remove option to paste rich text from Android EditText context menu #38189

fabOnReact · 2023-07-05T08:55:22Z

Summary:

Text is copy pasted as rich text on Android TextInput instead of Plain Text.

What is the root cause of that problem?

Android EditText and iOS UITextField/UITextView have different copy/paste behavior.

Android TextInput copies/pastes rich text
iOS UITextField copies/pastes plain text.

iOS (react-native)	Android (react-native)
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-27.at.21.41.04.mp4	repro_android.mov

What changes do you think we should make in order to solve the problem?

The issue is a bug in react-native #31442:

The JavaScript TextInput and ReactEditText Android state are not in sync
The TextInput Android Native state over-rides the JavaScript state.
onChangeText passes a plain text string to JavaScript, not rich text (text with spans and styles).

More info at Expensify/App#21411 (comment)

The solution consists of:

Over-riding onTextContextMenuItem in ReactEditText to copy/paste plain text instead of rich-text (https://stackoverflow.com/a/45319485/7295772).
Removing the Paste as plaintext option from the insert and selection context menu

fixes #31442

Changelog:

[ANDROID] [FIXED] - Remove option to paste rich text from Android EditText context menu

Test Plan:

Reproducing the issue on Android

2023-06-27.22-28-06.mp4

Fixing the issue on Android

Sourcecode https://github.com/fabriziobertoglio1987/text-input-cursor-flickering-android/blob/fix-copy-paste/app/src/main/java/com/example/myapplication/CustomEditText.java

2023-06-28.21-26-53.mp4

Testing the solution on React Native

2023-06-29.17-49-09.mp4

analysis-bot · 2023-07-05T09:21:05Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,843,572	-39,854
android	hermes	armeabi-v7a	8,152,772	+218,558
android	hermes	x86	9,349,392	+68,907
android	hermes	x86_64	9,192,090	+8,476
android	jsc	arm64-v8a	9,456,354	-16,762
android	jsc	armeabi-v7a	8,637,488	+221,011
android	jsc	x86	9,539,440	+83,566
android	jsc	x86_64	9,782,737	+10,654

Base commit: bae63d4
Branch: main

fabOnReact · 2023-07-14T08:42:07Z

Building the main branch with head 06668fc triggers a runtime when opening the RNTester Text examples:

CLICK TO OPEN STACKTRACE

07-22 21:29:39.711 10861 10931 E AndroidRuntime: FATAL EXCEPTION: FrescoIoBoundExecutor-2
07-22 21:29:39.711 10861 10931 E AndroidRuntime: Process: com.facebook.react.uiapp, PID: 10861
07-22 21:29:39.711 10861 10931 E AndroidRuntime: java.lang.UnsatisfiedLinkError: dlopen failed: library "libnative-imagetranscoder.so" not found
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at java.lang.Runtime.loadLibrary0(Runtime.java:1077)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at java.lang.Runtime.loadLibrary0(Runtime.java:998)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at java.lang.System.loadLibrary(System.java:1661)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.soloader.nativeloader.SystemDelegate.loadLibrary(SystemDelegate.java:24)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:52)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:30)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.nativecode.NativeJpegTranscoderSoLoader.ensure(NativeJpegTranscoderSoLoader.java:33)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.nativecode.NativeJpegTranscoder.<init>(NativeJpegTranscoder.java:59)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.nativecode.NativeJpegTranscoderFactory.createImageTranscoder(NativeJpegTranscoderFactory.java:43)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.transcoder.MultiImageTranscoderFactory.getNativeImageTranscoder(MultiImageTranscoderFactory.kt:59)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.transcoder.MultiImageTranscoderFactory.createImageTranscoder(MultiImageTranscoderFactory.kt:40)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.ResizeAndRotateProducer$TransformingConsumer.onNewResultImpl(ResizeAndRotateProducer.java:166)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.ResizeAndRotateProducer$TransformingConsumer.onNewResultImpl(ResizeAndRotateProducer.java:84)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.BaseConsumer.onNewResult(BaseConsumer.java:89)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.AddImageTransformMetaDataProducer$AddImageTransformMetaDataConsumer.onNewResultImpl(AddImageTransformMetaDataProducer.java:49)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.AddImageTransformMetaDataProducer$AddImageTransformMetaDataConsumer.onNewResultImpl(AddImageTransformMetaDataProducer.java:33)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.BaseConsumer.onNewResult(BaseConsumer.java:89)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.MultiplexProducer$Multiplexer.onNextResult(MultiplexProducer.java:510)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.MultiplexProducer$Multiplexer$ForwardingConsumer.onNewResultImpl(MultiplexProducer.java:569)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.MultiplexProducer$Multiplexer$ForwardingConsumer.onNewResultImpl(MultiplexProducer.java:562)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.BaseConsumer.onNewResult(BaseConsumer.java:89)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.EncodedMemoryCacheProducer$EncodedMemoryCacheConsumer.onNewResultImpl(EncodedMemoryCacheProducer.java:181)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.EncodedMemoryCacheProducer$EncodedMemoryCacheConsumer.onNewResultImpl(EncodedMemoryCacheProducer.java:123)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.BaseConsumer.onNewResult(BaseConsumer.java:89)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.DiskCacheReadProducer$1.then(DiskCacheReadProducer.java:113)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.producers.DiskCacheReadProducer$1.then(DiskCacheReadProducer.java:93)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.Task$14.run(Task.java:872)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.BoltsExecutors$ImmediateExecutor.execute(BoltsExecutors.java:105)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.Task.completeImmediately(Task.java:863)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.Task.access$000(Task.java:32)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.Task$10.then(Task.java:654)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.Task$10.then(Task.java:651)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.Task.runContinuations(Task.java:956)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.Task.trySetResult(Task.java:994)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.TaskCompletionSource.trySetResult(TaskCompletionSource.java:39)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.TaskCompletionSource.setResult(TaskCompletionSource.java:62)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at bolts.Task$4.run(Task.java:357)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.core.PriorityThreadFactory.newThread$lambda$0(PriorityThreadFactory.kt:37)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.core.PriorityThreadFactory.$r8$lambda$IPp7Vm9a1KDy8D4770JTjI9qOG4(Unknown Source:0)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at com.facebook.imagepipeline.core.PriorityThreadFactory$$ExternalSyntheticLambda0.run(Unknown Source:4)
07-22 21:29:39.711 10861 10931 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:1012)

2023-07-14.16-34-10.mp4

Related 823839b

...eact-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java

NickGerleman · 2023-07-17T20:13:04Z

Could you explain why you think the current behavior is a bug? At a glance, overriding a context menu command to paste rich text, to instead coerce to plain text, seems at odds with platform expectations.

fabOnReact · 2023-07-18T08:29:29Z

Thanks @NickGerleman

Could you explain why you think the current behavior is a bug?

FIRST REASON: It was reported as a react-native TextInput Issue in different chat applications:

Zulip Mobile Rich text can be pasted into input box on Android zulip/zulip-mobile#4660 (comment)

It's already the case that the only data TextInput actually exposes to the app is the plain text -- so the fact that it lets the user paste formatted text, and shows that formatting back, is basically a bug in RN because there's no way the app can end up respecting that formatting.

zulip/zulip-mobile#4660 (comment)

As described on this CZO thread, this issue can lead to a very awkward user experience.

SECOND REASON: React Native Controlled TextInput Component does not support paste with rich text.

Native and JavaScript state are not in sync.
The rich text pasted in the EditText over-rides the style of a JavaScript Controlled TextInput.

Example of a use case: The user pastes rich text in a JavaScript Controlled TextInput.

Expected behaviour:

The JavaScript Controlled TextInput manages the TextInput state and over-rides the Native Android State. The JavaScript TextInput and Text style props set the native text style.
onChangeText API is used to update the TextInput internal state and keep it sync with the updates from native.

Actual behaviour:

The JavaScript TextInput and Text style props do not change the style of the text.
onChangeText passes to JavaScript callback the plain text instead of rich text. It is not possible to keep the two states in sync.

2023-06-28.21-56-29.mp4

more info in comment Expensify/App#21411 (comment)

At a glance, overriding a context menu command to paste rich text, to instead coerce to plain text, seems at odds with platform expectations.

The fix is published as two PRs:

The first PR over-rides onTextContextMenuItem in ReactEditText to copy/paste plain text instead of rich-text #38189
The second PR removes the option paste as plain text #38210

The final result is that the option paste as plain text is removed, while paste becomes paste as plain text.

Before/After iOS	Before Android
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-27.at.21.41.04.mp4	repro_android.mov

After Android
2023-06-29.17-49-09.mp4

NickGerleman

Could we combine #38210 into this so that we get both changes at once? Otherwise this makes sense to me, if the application can never have visibility into the rich text.

facebook#38189 (review)

facebook-github-bot · 2023-07-27T05:40:31Z

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2023-07-28T17:39:25Z

@NickGerleman merged this pull request in b1ceea4.

…acebook#38189) Summary: Text is copy pasted as rich text on Android TextInput instead of Plain Text. ### What is the root cause of that problem? Android EditText and iOS UITextField/UITextView have different copy/paste behavior. - Android TextInput copies/pastes rich text - iOS UITextField copies/pastes plain text. | iOS (react-native) | Android (react-native) | | ----------- | ----------- | | <video src="https://user-images.githubusercontent.com/24992535/249170968-8fde35f0-a53c-4c5c-bd89-ee822c08eadf.mp4" width="350" /> | <video src="https://user-images.githubusercontent.com/24992535/249171968-bf0915a0-4060-4586-b267-7c2b463d76f6.mov" width="350" /> | ### What changes do you think we should make in order to solve the problem? The issue is a bug in react-native facebook#31442: 1) The JavaScript TextInput and ReactEditText Android state are not in sync 2) The TextInput Android Native state over-rides the JavaScript state. 3) onChangeText passes a plain text string to JavaScript, not rich text (text with spans and styles). More info at Expensify/App#21411 (comment) The solution consists of: 1) **Over-riding onTextContextMenuItem in ReactEditText to copy/paste plain text instead of rich-text** (https://stackoverflow.com/a/45319485/7295772). 2) **Removing the `Paste as plaintext` option from the insert and selection context menu** fixes facebook#31442 ## Changelog: [ANDROID] [FIXED] - Remove option to paste rich text from Android EditText context menu Pull Request resolved: facebook#38189 Test Plan: #### Reproducing the issue on Android https://user-images.githubusercontent.com/24992535/249185416-76f8a687-1aca-4dc9-9abe-3d73d6e2893c.mp4 #### Fixing the issue on Android Sourcecode https://github.com/fabriziobertoglio1987/text-input-cursor-flickering-android/blob/fix-copy-paste/app/src/main/java/com/example/myapplication/CustomEditText.java https://user-images.githubusercontent.com/24992535/249486339-95449bb9-71b6-430c-8207-f5672f034fa9.mp4 #### Testing the solution on React Native https://github.com/Expensify/App/assets/24992535/b302237b-99e5-44a2-996d-8bc50bbbc95c Reviewed By: mdvacca Differential Revision: D47824730 Pulled By: NickGerleman fbshipit-source-id: 35525e7d52e664b0f78649d23941262ee45a00cd

…38189) Summary: Text is copy pasted as rich text on Android TextInput instead of Plain Text. ### What is the root cause of that problem? Android EditText and iOS UITextField/UITextView have different copy/paste behavior. - Android TextInput copies/pastes rich text - iOS UITextField copies/pastes plain text. | iOS (react-native) | Android (react-native) | | ----------- | ----------- | | <video src="https://user-images.githubusercontent.com/24992535/249170968-8fde35f0-a53c-4c5c-bd89-ee822c08eadf.mp4" width="350" /> | <video src="https://user-images.githubusercontent.com/24992535/249171968-bf0915a0-4060-4586-b267-7c2b463d76f6.mov" width="350" /> | ### What changes do you think we should make in order to solve the problem? The issue is a bug in react-native #31442: 1) The JavaScript TextInput and ReactEditText Android state are not in sync 2) The TextInput Android Native state over-rides the JavaScript state. 3) onChangeText passes a plain text string to JavaScript, not rich text (text with spans and styles). More info at Expensify/App#21411 (comment) The solution consists of: 1) **Over-riding onTextContextMenuItem in ReactEditText to copy/paste plain text instead of rich-text** (https://stackoverflow.com/a/45319485/7295772). 2) **Removing the `Paste as plaintext` option from the insert and selection context menu** fixes #31442 ## Changelog: [ANDROID] [FIXED] - Remove option to paste rich text from Android EditText context menu Pull Request resolved: #38189 Test Plan: #### Reproducing the issue on Android https://user-images.githubusercontent.com/24992535/249185416-76f8a687-1aca-4dc9-9abe-3d73d6e2893c.mp4 #### Fixing the issue on Android Sourcecode https://github.com/fabriziobertoglio1987/text-input-cursor-flickering-android/blob/fix-copy-paste/app/src/main/java/com/example/myapplication/CustomEditText.java https://user-images.githubusercontent.com/24992535/249486339-95449bb9-71b6-430c-8207-f5672f034fa9.mp4 #### Testing the solution on React Native https://github.com/Expensify/App/assets/24992535/b302237b-99e5-44a2-996d-8bc50bbbc95c Reviewed By: mdvacca Differential Revision: D47824730 Pulled By: NickGerleman fbshipit-source-id: 35525e7d52e664b0f78649d23941262ee45a00cd

…acebook#38189) Summary: Text is copy pasted as rich text on Android TextInput instead of Plain Text. ### What is the root cause of that problem? Android EditText and iOS UITextField/UITextView have different copy/paste behavior. - Android TextInput copies/pastes rich text - iOS UITextField copies/pastes plain text. | iOS (react-native) | Android (react-native) | | ----------- | ----------- | | <video src="https://user-images.githubusercontent.com/24992535/249170968-8fde35f0-a53c-4c5c-bd89-ee822c08eadf.mp4" width="350" /> | <video src="https://user-images.githubusercontent.com/24992535/249171968-bf0915a0-4060-4586-b267-7c2b463d76f6.mov" width="350" /> | ### What changes do you think we should make in order to solve the problem? The issue is a bug in react-native facebook#31442: 1) The JavaScript TextInput and ReactEditText Android state are not in sync 2) The TextInput Android Native state over-rides the JavaScript state. 3) onChangeText passes a plain text string to JavaScript, not rich text (text with spans and styles). More info at Expensify/App#21411 (comment) The solution consists of: 1) **Over-riding onTextContextMenuItem in ReactEditText to copy/paste plain text instead of rich-text** (https://stackoverflow.com/a/45319485/7295772). 2) **Removing the `Paste as plaintext` option from the insert and selection context menu** fixes facebook#31442 ## Changelog: [ANDROID] [FIXED] - Remove option to paste rich text from Android EditText context menu Pull Request resolved: facebook#38189 Test Plan: #### Reproducing the issue on Android https://user-images.githubusercontent.com/24992535/249185416-76f8a687-1aca-4dc9-9abe-3d73d6e2893c.mp4 #### Fixing the issue on Android Sourcecode https://github.com/fabriziobertoglio1987/text-input-cursor-flickering-android/blob/fix-copy-paste/app/src/main/java/com/example/myapplication/CustomEditText.java https://user-images.githubusercontent.com/24992535/249486339-95449bb9-71b6-430c-8207-f5672f034fa9.mp4 #### Testing the solution on React Native https://github.com/Expensify/App/assets/24992535/b302237b-99e5-44a2-996d-8bc50bbbc95c Reviewed By: mdvacca Differential Revision: D47824730 Pulled By: NickGerleman fbshipit-source-id: 35525e7d52e664b0f78649d23941262ee45a00cd

fabOnReact added 2 commits July 5, 2023 16:26

paste as paste as plain text

6ddeb0b

change method order

a94cb55

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 5, 2023

fabOnReact changed the title ~~over-riding onTextContextMenuItem in ReactEditText to copy/paste plain text instead of rich-text~~ Over-riding onTextContextMenuItem in ReactEditText to copy/paste plain text instead of rich-text Jul 5, 2023

fabOnReact mentioned this pull request Jul 6, 2023

Removing the Paste as plaintext option from the insert and selection context menu #38210

Closed

adding comments

7fb987c

fabOnReact mentioned this pull request Jul 6, 2023

[HOLD for payment 2023-09-29] [$1000] Android - Login - Linkified email from external app is pasted as linkified email in email field Expensify/App#21411

Closed

6 tasks

Merge branch 'main' into fix-copy-paste

d0393a2

fabOnReact commented Jul 17, 2023

View reviewed changes

...eact-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java Outdated Show resolved Hide resolved

fabOnReact added 2 commits July 17, 2023 15:34

Merge branch 'main' into fix-copy-paste

340d7e7

minor changes

566506b

fabOnReact marked this pull request as ready for review July 17, 2023 08:30

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 17, 2023

fabOnReact marked this pull request as draft July 17, 2023 11:50

for some reason, import was removed by linter

2e4c9f1

fabOnReact marked this pull request as ready for review July 17, 2023 11:57

fabOnReact marked this pull request as draft July 17, 2023 12:00

fabOnReact marked this pull request as ready for review July 17, 2023 12:31

NickGerleman approved these changes Jul 22, 2023

View reviewed changes

fabOnReact marked this pull request as draft July 22, 2023 06:56

fabOnReact added 3 commits July 22, 2023 15:11

changes requested by code-review

51accb9

facebook#38189 (review)

Merge branch 'main' into fix-copy-paste

e2ed6f3

Merge branch 'main' into fix-copy-paste

0a6b3f1

fabOnReact changed the title ~~Over-riding onTextContextMenuItem in ReactEditText to copy/paste plain text instead of rich-text~~ Remove option to paste rich text from Android EditText context menu Jul 22, 2023

fabOnReact added 2 commits July 23, 2023 09:24

Merge branch 'main' into fix-copy-paste

00cd9ca

Merge branch 'main' into fix-copy-paste

597a487

fabOnReact marked this pull request as draft July 26, 2023 13:44

fabOnReact added 2 commits July 26, 2023 21:48

restore the original clipboard < API 23

1977d08

refactor logic that restore clipboard to previous state

6cb401b

fabOnReact marked this pull request as ready for review July 27, 2023 03:39

facebook-github-bot closed this in b1ceea4 Jul 28, 2023

facebook-github-bot added the Merged This PR has been merged. label Jul 28, 2023

gnprice mentioned this pull request Jul 31, 2023

Rich text can be pasted into input box on Android zulip/zulip-mobile#4660

Open

This was referenced Aug 10, 2023

[LOCAL] Fix Ruby Tests for 0.72 #38919

Closed

[LOCAL] Add script poll maven #38980

Merged

NOUIY mentioned this pull request Sep 4, 2023

[Snyk] Upgrade react-native from 0.63.3 to 0.72.4 NOUIY/react-native-macos#1143

Open

cipolleschi mentioned this pull request Sep 21, 2023

[LOCAL] Copy hermes ruby files to hermes folder in local E2E test #39575

Merged

cipolleschi mentioned this pull request Oct 12, 2023

[Local] Fix CI for 0.72, with Acitve Support and Xcode15 #40855

Merged

cipolleschi mentioned this pull request Nov 1, 2023

[RN][CI]Update node installation on debian (0.72) #41276

Merged

cipolleschi mentioned this pull request Dec 27, 2023

[RN][iOS] Improve Swift support for 3rd party libs #42075

Merged

This was referenced Feb 28, 2024

[RN][IOS] Fix flags for new arch #43240

Merged

[RN][iOS]Rename BUILD_FROM_SOURCE to RCT_BUILD_HERMES_FROM_SOURCE #43247

Merged

[RN][iOS][0.72] Fix flipper for Xcode 15.3 #43344

Merged

cipolleschi mentioned this pull request Jun 28, 2024

[CI] Move machines to M1 for 0.72 #45215

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove option to paste rich text from Android EditText context menu #38189

Remove option to paste rich text from Android EditText context menu #38189

fabOnReact commented Jul 5, 2023 •

edited

Loading

analysis-bot commented Jul 5, 2023 •

edited

Loading

fabOnReact commented Jul 14, 2023 •

edited

Loading

NickGerleman commented Jul 17, 2023

fabOnReact commented Jul 18, 2023

NickGerleman left a comment

facebook-github-bot commented Jul 27, 2023

facebook-github-bot commented Jul 28, 2023

Remove option to paste rich text from Android EditText context menu #38189

Remove option to paste rich text from Android EditText context menu #38189

Conversation

fabOnReact commented Jul 5, 2023 • edited Loading

Summary:

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Changelog:

Test Plan:

Reproducing the issue on Android

Fixing the issue on Android

Testing the solution on React Native

analysis-bot commented Jul 5, 2023 • edited Loading

fabOnReact commented Jul 14, 2023 • edited Loading

NickGerleman commented Jul 17, 2023

fabOnReact commented Jul 18, 2023

NickGerleman left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Jul 27, 2023

facebook-github-bot commented Jul 28, 2023

fabOnReact commented Jul 5, 2023 •

edited

Loading

analysis-bot commented Jul 5, 2023 •

edited

Loading

fabOnReact commented Jul 14, 2023 •

edited

Loading