-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the Paste as plaintext option from the insert and selection context menu #38210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 6, 2023
fabOnReact
changed the title
Remove Paste as plaintext from Android EditText context menu.
Removing the Jul 6, 2023
Paste as plaintext
option from the insert and selection context menu
fabOnReact
changed the title
Removing the
Removing the Paste as plaintext option from the insert and selection context menu
Jul 6, 2023
Paste as plaintext
option from the insert and selection context menu
Base commit: 8ab9a77 |
6 tasks
facebook-github-bot
added
the
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Jul 17, 2023
Changes from this PR moved to #38189 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove
Paste as plaintext
from Android EditText context menu.Related PR Over-riding onTextContextMenuItem in ReactEditText to copy/paste plain text instead of rich-text #38189.
What is the root cause of that problem?
Android EditText and iOS UITextField/UITextView have different copy/paste behavior.
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-27.at.21.41.04.mp4
repro_android.mov
What changes do you think we should make in order to solve the problem?
The issue is a bug in react-native #31442:
More info at Expensify/App#21411 (comment)
The solution consists of:
Paste as plaintext
option from the insert and selection context menu #38210Changelog:
[ANDROID] [FIXED] - Remove Paste as plaintext from Android EditText context menu.
Test Plan:
Reproducing the issue on Android
2023-06-27.22-28-06.mp4
Fixing the issue on Android
Sourcecode https://github.com/fabriziobertoglio1987/text-input-cursor-flickering-android/blob/fix-copy-paste/app/src/main/java/com/example/myapplication/CustomEditText.java
2023-06-28.21-26-53.mp4
Testing the solution on React Native
2023-06-29.17-49-09.mp4
More tests at Expensify/App#21411 (comment)