Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly declare runtime dependencies #41445

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented Nov 13, 2023

Summary:

In pnpm setups, codegen will fail during build because it cannot find its dependencies. Some of the dependencies it relies on at runtime are currently declared under devDependencies. This change moves them to dependencies.

Cherry-picks c58e19e.

Changelog:

[GENERAL] [FIXED] - Fix react-native/codegen not being able to resolve dependencies in pnpm setups

Test Plan:

We are currently trying to enable pnpm mode in rnx-kit and hit this issue. We've patched this package locally and it works.

In pnpm setups, codegen will fail during build because it cannot find
its dependencies. Some of the dependencies it relies on at runtime are
currently declared under `devDependencies`. This change moves them to
`dependencies`.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants