Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.72] Integrate 0.72.14 #13243

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

TatianaKapos
Copy link
Contributor

@TatianaKapos TatianaKapos commented May 16, 2024

@TatianaKapos
Copy link
Contributor Author

Looks like the node-18 tests have been failing on CI for awhile now. The node tests were switched to 18 in #12693 and then we reverted some tests back to 16 in #12709 but not the node tests. Switched back to node 16 tests to see if they'll pass.

@jonthysell or @acoates-ms are we fine to make the switch back to node 16 tests?

@TatianaKapos TatianaKapos changed the title [Draft] [0.72] Integrate 0.72.14 [0.72] Integrate 0.72.14 May 17, 2024
@TatianaKapos TatianaKapos marked this pull request as ready for review May 17, 2024 21:25
@TatianaKapos TatianaKapos requested review from a team as code owners May 17, 2024 21:25
@acoates-ms
Copy link
Contributor

The point of the node 18 test was to ensure that we work if the user has node 18 installed. I dont think we care to much about trying to forward support node versions in the stable branches. I'd have bene ok completely disabling / deleting the node 18 job from the stable branch.

@TatianaKapos TatianaKapos merged commit 64e5b31 into microsoft:0.72-stable May 20, 2024
78 checks passed
@TatianaKapos TatianaKapos deleted the t-upgrade-72 branch May 20, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants