Update getDefaultJSExecutorFactory to load Hermes first and fallback to JSC #41914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52080545 |
Base commit: f676f42 |
…to JSC (facebook#41914) Summary: If the user does not specify which engine they're using, we still default to loading JSC first and then attempting to load Hermes. This has a small performance hit (as we attempt to load an existing library) + it prints an inactionable log for the user every time. Changelog: [Android] [Fixed] - Update getDefaultJSExecutorFactory to load Hermes first and fallback to JSC Reviewed By: luluwu2032 Differential Revision: D52080545
cortinico
force-pushed
the
export-D52080545
branch
from
cce439e
to
607a21e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52080545 |
|
This pull request has been merged in 70a757f. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…to JSC (facebook#41914) Summary: Pull Request resolved: facebook#41914 If the user does not specify which engine they're using, we still default to loading JSC first and then attempting to load Hermes. This has a small performance hit (as we attempt to load an existing library) + it prints an inactionable log for the user every time. Changelog: [Android] [Fixed] - Update getDefaultJSExecutorFactory to load Hermes first and fallback to JSC Reviewed By: luluwu2032 Differential Revision: D52080545 fbshipit-source-id: 95f37304d713da7d7079eabbd2dfdf230d29a1b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If the user does not specify which engine they're using, we still default to loading JSC first and then attempting to load Hermes.
This has a small performance hit (as we attempt to load an existing library) + it prints an inactionable log for the user every time.
Changelog:
[Android] [Fixed] - Update getDefaultJSExecutorFactory to load Hermes first and fallback to JSC
Differential Revision: D52080545