Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getDefaultJSExecutorFactory to load Hermes first and fallback to JSC #41914

Closed
wants to merge 1 commit into from
Closed

Update getDefaultJSExecutorFactory to load Hermes first and fallback to JSC #41914

wants to merge 1 commit into from

Commits on Dec 13, 2023

  1. Update getDefaultJSExecutorFactory to load Hermes first and fallback … 

    …to JSC (facebook#41914)

Summary:

If the user does not specify which engine they're using, we still default to loading JSC first and then attempting to load Hermes.
This has a small performance hit (as we attempt to load an existing library) + it prints an inactionable log for the user every time.

Changelog:
[Android] [Fixed] - Update getDefaultJSExecutorFactory to load Hermes first and fallback to JSC

Reviewed By: luluwu2032

Differential Revision: D52080545
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    607a21e View commit details
    Browse the repository at this point in the history