Remove mapbuffer from early js error handling #43951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55265170 |
Base commit: 5927165 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [General][Breaking] - Migrate early js error handling infra off MapBuffer to structs/classes Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [General][Breaking] - Migrate early js error handling infra off MapBuffer to structs/classes Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [General][Breaking] - Migrate early js error handling infra off MapBuffer to structs/classes Reviewed By: fkgozali Differential Revision: D55265170
|
This pull request was exported from Phabricator. Differential Revision: D55265170 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [General][Breaking] - Migrate early js error handling infra off MapBuffer to structs/classes Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [General][Breaking] - Migrate early js error handling infra off MapBuffer to structs/classes Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [General][Breaking] - Migrate early js error handling infra off MapBuffer to structs/classes Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Breaking][General] - Remove mapbuffer from early js error handling Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 7, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: ## Context The **early js** error reporting pipeline catches javascript exceptions. After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨 ## Problems We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs). Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni. ## Changes Migrate the **early js** error handling infra to C++ structs/fbjni. ## Impact Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D55265170
|
This pull request has been merged in b52c7aa. |
|
This pull request was successfully merged by @RSNara in b52c7aa. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
The early js error reporting pipeline catches javascript exceptions.
After errors are caught, the pipeline parses the exception, and puts the data into into a map buffer. 🤨
Problems
We don't need to use a mapbuffer here: The structure of this exception data is known and never changes. (A map buffer is a type-unsafe bag of key/value pairs).
Instead, we could just use lower-level type-safe language primitives: regular C++ struct, and java class w/ fbjni.
Changes
Migrate the early js error handling infra to C++ structs/fbjni.
Impact
Now, there is no mapbuffer usage on iOS. We could re-introduce it when there is a need.
Changelog: [General][Breaking] - Migrate early js error handling infra off MapBuffer to structs/classes
Reviewed By: fkgozali
Differential Revision: D55265170