Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration 04/13/24 (1b152f6ec) #13226

Merged
merged 13 commits into from
May 14, 2024
Merged

Conversation

marlenecota
Copy link
Contributor

@marlenecota marlenecota commented May 13, 2024

@marlenecota marlenecota changed the title Integration 04/06/24 (1b152f6ec) Integration 04/13/24 (1b152f6ec) May 13, 2024
@marlenecota marlenecota marked this pull request as ready for review May 14, 2024 01:43
@marlenecota marlenecota requested review from a team as code owners May 14, 2024 01:43
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request May 14, 2024
…size_t (#44564)

Summary:
The RNW integration to RN 04/13 (microsoft/react-native-windows#13226) adds EventPerformanceLogger.cpp and PerformanceEntryReporter.cpp.

We're getting the following errors:
![image](https://github.com/facebook/react-native/assets/1422161/33a4dc42-1d14-4ac4-befd-87ec5cd02640)

![image](https://github.com/facebook/react-native/assets/1422161/6269968d-c0e8-489b-992e-0bb41b6ef7c6)

Switching to size_t fixes it.

## Changelog:
[Internal] [FIXED] - EventPerformanceLogger + BoundedConsumableBuffer - switch members to size_t

Pull Request resolved: #44564

Test Plan: Builds on Windows

Reviewed By: fabriziocucci

Differential Revision: D57327696

Pulled By: javache

fbshipit-source-id: 21ec3a9597958aa70fbca64710bd615a1022292d
@marlenecota marlenecota enabled auto-merge (squash) May 14, 2024 18:51
@marlenecota marlenecota merged commit 1db259b into microsoft:main May 14, 2024
53 checks passed
@marlenecota marlenecota deleted the integration-0413 branch May 14, 2024 18:52
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
…size_t (facebook#44564)

Summary:
The RNW integration to RN 04/13 (microsoft/react-native-windows#13226) adds EventPerformanceLogger.cpp and PerformanceEntryReporter.cpp.

We're getting the following errors:
![image](https://github.com/facebook/react-native/assets/1422161/33a4dc42-1d14-4ac4-befd-87ec5cd02640)

![image](https://github.com/facebook/react-native/assets/1422161/6269968d-c0e8-489b-992e-0bb41b6ef7c6)

Switching to size_t fixes it.

## Changelog:
[Internal] [FIXED] - EventPerformanceLogger + BoundedConsumableBuffer - switch members to size_t

Pull Request resolved: facebook#44564

Test Plan: Builds on Windows

Reviewed By: fabriziocucci

Differential Revision: D57327696

Pulled By: javache

fbshipit-source-id: 21ec3a9597958aa70fbca64710bd615a1022292d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants