Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove faviconUrl field from CDP list response #44834

Closed
wants to merge 1 commit into from
Closed

Remove faviconUrl field from CDP list response #44834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/dev-middleware/src/__tests__/InspectorProxyHttpApi-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ describe('inspector proxy HTTP API', () => {
description: 'bar-app',
deviceName: 'foo',
devtoolsFrontendUrl: expect.any(String),
faviconUrl: 'https://reactjs.org/favicon.ico',
id: 'device1-page1',
reactNative: {
capabilities: {},
Expand All @@ -203,7 +202,6 @@ describe('inspector proxy HTTP API', () => {
description: 'bar-app',
deviceName: 'foo',
devtoolsFrontendUrl: expect.any(String),
faviconUrl: 'https://reactjs.org/favicon.ico',
id: 'device2-page1',
reactNative: {
capabilities: {},
Expand Down
5 changes: 2 additions & 3 deletions packages/dev-middleware/src/inspector-proxy/InspectorProxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,10 @@ export default class InspectorProxy implements InspectorProxyQueries {

return {
id: `${deviceId}-${page.id}`,
description: page.app,
title: page.title,
faviconUrl: 'https://reactjs.org/favicon.ico',
devtoolsFrontendUrl,
description: page.app,
type: 'node',
devtoolsFrontendUrl,
webSocketDebuggerUrl,
vm: page.vm,
deviceName: device.getName(),
Expand Down
10 changes: 6 additions & 4 deletions packages/dev-middleware/src/inspector-proxy/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,17 @@ export type MessageToDevice =
// Page description object that is sent in response to /json HTTP request from debugger.
export type PageDescription = $ReadOnly<{
id: string,
description: string,
title: string,
faviconUrl: string,
devtoolsFrontendUrl: string,
description: string,
type: string,
devtoolsFrontendUrl: string,
webSocketDebuggerUrl: string,

// React Native specific fields
deviceName: string,
vm: string,
// Metadata specific to React Native

// React Native specific metadata
reactNative: $ReadOnly<{
logicalDeviceId: string,
capabilities: Page['capabilities'],
Expand Down
Loading