Remove faviconUrl field from CDP list response #44834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Remove the nonstandard, unused `faviconUrl` field from CDP `/json` response targets (note: both legacy and modern targets). - Reorder `PageDescription` members. Changelog: [General][Removed] - `react-native/dev-middleware`: Remove nonstandard `faviconUrl` field from CDP `/json` response Differential Revision: D58092090
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58092090 |
|
This pull request has been merged in df19e59. |
|
This pull request was successfully merged by @huntie in df19e59. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44834 - Remove the nonstandard, unused `faviconUrl` field from CDP `/json` response targets (note: both legacy and modern targets). - Reorder `PageDescription` members. Changelog: [General][Removed] - `react-native/dev-middleware`: Remove nonstandard `faviconUrl` field from CDP `/json` response Reviewed By: hoxyq Differential Revision: D58092090 fbshipit-source-id: a593be00464853a3fe179305efae5643d616573b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
faviconUrlfield from CDP/jsonresponse targets (note: both legacy and modern targets).PageDescriptionmembers.Changelog:
[General][Removed] -
react-native/dev-middleware: Remove nonstandardfaviconUrlfield from CDP/jsonresponseDifferential Revision: D58092090