Remove faviconUrl field from CDP list response (facebook#44834)

Summary: Pull Request resolved: facebook#44834 - Remove the nonstandard, unused `faviconUrl` field from CDP `/json` response targets (note: both legacy and modern targets). - Reorder `PageDescription` members. Changelog: [General][Removed] - `react-native/dev-middleware`: Remove nonstandard `faviconUrl` field from CDP `/json` response Reviewed By: hoxyq Differential Revision: D58092090 fbshipit-source-id: a593be00464853a3fe179305efae5643d616573b
kosmydel · Jun 11, 2024 · 6e48cf7 · 6e48cf7
1 parent 728d773
commit 6e48cf7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/packages/dev-middleware/src/__tests__/InspectorProxyHttpApi-test.js b/packages/dev-middleware/src/__tests__/InspectorProxyHttpApi-test.js
@@ -188,7 +188,6 @@ describe('inspector proxy HTTP API', () => {
             description: 'bar-app',
             deviceName: 'foo',
             devtoolsFrontendUrl: expect.any(String),
-            faviconUrl: 'https://reactjs.org/favicon.ico',
             id: 'device1-page1',
             reactNative: {
               capabilities: {},
@@ -203,7 +202,6 @@ describe('inspector proxy HTTP API', () => {
             description: 'bar-app',
             deviceName: 'foo',
             devtoolsFrontendUrl: expect.any(String),
-            faviconUrl: 'https://reactjs.org/favicon.ico',
             id: 'device2-page1',
             reactNative: {
               capabilities: {},

diff --git a/packages/dev-middleware/src/inspector-proxy/InspectorProxy.js b/packages/dev-middleware/src/inspector-proxy/InspectorProxy.js
@@ -155,11 +155,10 @@ export default class InspectorProxy implements InspectorProxyQueries {
 
     return {
       id: `${deviceId}-${page.id}`,
-      description: page.app,
       title: page.title,
-      faviconUrl: 'https://reactjs.org/favicon.ico',
-      devtoolsFrontendUrl,
+      description: page.app,
       type: 'node',
+      devtoolsFrontendUrl,
       webSocketDebuggerUrl,
       vm: page.vm,
       deviceName: device.getName(),

diff --git a/packages/dev-middleware/src/inspector-proxy/types.js b/packages/dev-middleware/src/inspector-proxy/types.js
@@ -108,15 +108,17 @@ export type MessageToDevice =
 // Page description object that is sent in response to /json HTTP request from debugger.
 export type PageDescription = $ReadOnly<{
   id: string,
-  description: string,
   title: string,
-  faviconUrl: string,
-  devtoolsFrontendUrl: string,
+  description: string,
   type: string,
+  devtoolsFrontendUrl: string,
   webSocketDebuggerUrl: string,
+
+  // React Native specific fields
   deviceName: string,
   vm: string,
-  // Metadata specific to React Native
+
+  // React Native specific metadata
   reactNative: $ReadOnly<{
     logicalDeviceId: string,
     capabilities: Page['capabilities'],