Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure updates are applied when diffInCommitPhase is on #26977

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Ensure updates are applied when diffInCommitPhase is on #26977

merged 2 commits into from
Jun 20, 2023

Commits on Jun 20, 2023

  1. Ensure updates are applied when diffInCommitPhase is on 

    In this case there's no updatePayload.
    @sebmarkbage
    sebmarkbage committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a108580 View commit details
    Browse the repository at this point in the history

  2. Clarify that updateHostComponent is unnecessary in the new flag 

    We reuse updateHostComponent for HostSingleton and HostHoistables since it
has a somewhat complex path but that means you have to remember when editing
updateHostComponent that it's not just used for that tag.

Luckily with the new flag, this is actually unnecessary since we just need
to mark it for update if any props have changed and then we diff it later.
    @sebmarkbage
    sebmarkbage committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b8a8b0a View commit details
    Browse the repository at this point in the history