Ensure updates are applied when diffInCommitPhase is on #26977

sebmarkbage · 2023-06-20T00:46:58Z

When we diffInCommitPhase there's no updatePayload, which caused no update to be applied.

This is unfortunate because it would've been a lot easier to see this oversight if we didn't have to support both flags.

I also carified that updateHostComponent is unnecessary in the new flag. We reuse updateHostComponent for HostSingleton and HostHoistables since it has a somewhat complex path but that means you have to remember when editing updateHostComponent that it's not just used for that tag. Luckily with the new flag, this is actually unnecessary since we just need to mark it for update if any props have changed and then we diff it later.

In this case there's no updatePayload.

We reuse updateHostComponent for HostSingleton and HostHoistables since it has a somewhat complex path but that means you have to remember when editing updateHostComponent that it's not just used for that tag. Luckily with the new flag, this is actually unnecessary since we just need to mark it for update if any props have changed and then we diff it later.

react-sizebot · 2023-06-20T00:51:43Z

Comparing: 613e6f5...b8a8b0a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	164.56 kB	164.56 kB	=	51.83 kB	51.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	172.00 kB	171.97 kB	=	54.07 kB	54.06 kB
facebook-www/ReactDOM-prod.classic.js	+0.06%	571.13 kB	571.47 kB	+0.02%	100.75 kB	100.78 kB
facebook-www/ReactDOM-prod.modern.js	+0.06%	554.91 kB	555.25 kB	+0.03%	97.93 kB	97.96 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against b8a8b0a

When we diffInCommitPhase there's no updatePayload, which caused no update to be applied. This is unfortunate because it would've been a lot easier to see this oversight if we didn't have to support both flags. I also carified that updateHostComponent is unnecessary in the new flag. We reuse updateHostComponent for HostSingleton and HostHoistables since it has a somewhat complex path but that means you have to remember when editing updateHostComponent that it's not just used for that tag. Luckily with the new flag, this is actually unnecessary since we just need to mark it for update if any props have changed and then we diff it later. DiffTrain build for [d1c8cda](d1c8cda)

When we diffInCommitPhase there's no updatePayload, which caused no update to be applied. This is unfortunate because it would've been a lot easier to see this oversight if we didn't have to support both flags. I also carified that updateHostComponent is unnecessary in the new flag. We reuse updateHostComponent for HostSingleton and HostHoistables since it has a somewhat complex path but that means you have to remember when editing updateHostComponent that it's not just used for that tag. Luckily with the new flag, this is actually unnecessary since we just need to mark it for update if any props have changed and then we diff it later.

When we diffInCommitPhase there's no updatePayload, which caused no update to be applied. This is unfortunate because it would've been a lot easier to see this oversight if we didn't have to support both flags. I also carified that updateHostComponent is unnecessary in the new flag. We reuse updateHostComponent for HostSingleton and HostHoistables since it has a somewhat complex path but that means you have to remember when editing updateHostComponent that it's not just used for that tag. Luckily with the new flag, this is actually unnecessary since we just need to mark it for update if any props have changed and then we diff it later. DiffTrain build for commit d1c8cda.

sebmarkbage added 2 commits June 19, 2023 20:31

Ensure updates are applied when diffInCommitPhase is on

a108580

In this case there's no updatePayload.

sebmarkbage requested review from gnoff and acdlite June 20, 2023 00:46

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 20, 2023

acdlite approved these changes Jun 20, 2023

View reviewed changes

sebmarkbage merged commit d1c8cda into facebook:main Jun 20, 2023

This was referenced Jun 25, 2023

Upgrade vendored React vercel/next.js#51779

Closed

chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 vercel/next.js#52005

Merged

styfle mentioned this pull request Jul 5, 2023

chore(deps): bump react to 7118f5dd7 vercel/next.js#52282

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure updates are applied when diffInCommitPhase is on #26977

Ensure updates are applied when diffInCommitPhase is on #26977

sebmarkbage commented Jun 20, 2023

react-sizebot commented Jun 20, 2023

Ensure updates are applied when diffInCommitPhase is on #26977

Ensure updates are applied when diffInCommitPhase is on #26977

Conversation

sebmarkbage commented Jun 20, 2023

react-sizebot commented Jun 20, 2023

Critical size changes

Significant size changes