Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiber][Float] preinitialized stylesheets should support integrity option #26881

Merged
merged 1 commit into from
May 31, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented May 31, 2023

preinitialized stylesheets did not render the integrity option on the client implementation of Float. This was an oversight.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 31, 2023
… client implementation of Float. This was an oversight.
@gnoff gnoff force-pushed the bugfix-missing-integrity branch from 2f2a705 to 683a714 Compare May 31, 2023 18:28
@react-sizebot
Copy link

react-sizebot commented May 31, 2023

Comparing: 1cea384...683a714

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.01% 164.25 kB 164.28 kB = 51.79 kB 51.79 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.01% 171.69 kB 171.72 kB = 54.02 kB 54.03 kB
facebook-www/ReactDOM-prod.classic.js = 570.48 kB 570.52 kB = 100.66 kB 100.66 kB
facebook-www/ReactDOM-prod.modern.js = 554.22 kB 554.26 kB = 97.84 kB 97.84 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 683a714

@gnoff gnoff merged commit e1e68b9 into facebook:main May 31, 2023
@gnoff gnoff deleted the bugfix-missing-integrity branch May 31, 2023 20:48
github-actions bot pushed a commit that referenced this pull request May 31, 2023
…tion (#26881)

preinitialized stylesheets did not render the integrity option on the
client implementation of Float. This was an oversight.

DiffTrain build for [e1e68b9](e1e68b9)
@gnoff gnoff removed the request for review from acdlite May 31, 2023 21:27
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…tion (facebook#26881)

preinitialized stylesheets did not render the integrity option on the
client implementation of Float. This was an oversight.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…tion (#26881)

preinitialized stylesheets did not render the integrity option on the
client implementation of Float. This was an oversight.

DiffTrain build for commit e1e68b9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants