Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disableStrictPassiveEffect not working under Suspense #26989

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

tyao1
Copy link
Contributor

@tyao1 tyao1 commented Jun 21, 2023

In #26914 I added an extra logic to turn off effect if disableStrictPassiveEffect is an Offscreen tag. But Suspense uses Offscreen tag internally and that turns off disableStrictPassiveEffect for everything.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 21, 2023
@tyao1 tyao1 merged commit 70e998a into main Jun 22, 2023
github-actions bot pushed a commit that referenced this pull request Jun 22, 2023
In #26914 I added an extra logic
to turn off double useEffect if there is an `Offscreen`
tag. But `Suspense` uses `Offscreen` tag internally and that turns off
`disableStrictPassiveEffect` for everything.

DiffTrain build for [70e998a](70e998a)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…6989)

In facebook#26914 I added an extra logic
to turn off double useEffect if there is an `Offscreen`
tag. But `Suspense` uses `Offscreen` tag internally and that turns off
`disableStrictPassiveEffect` for everything.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
In #26914 I added an extra logic
to turn off double useEffect if there is an `Offscreen`
tag. But `Suspense` uses `Offscreen` tag internally and that turns off
`disableStrictPassiveEffect` for everything.

DiffTrain build for commit 70e998a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants