[Fiber] Use a safer strategy to track the last precedence #28110

gnoff · 2024-01-26T16:10:11Z

Uses a safer strategy to track the last precedence to avoid the need to consistently remember to preprend 'p' to the precedence value

…to consistently remember to preprend 'p' to the precedence value

react-sizebot · 2024-01-26T16:15:02Z

Comparing: 7636126...bdf6467

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.65 kB	176.63 kB	=	55.01 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.75 kB	178.73 kB	=	55.64 kB	55.63 kB
facebook-www/ReactDOM-prod.classic.js	=	573.67 kB	573.64 kB	=	101.01 kB	101.01 kB
facebook-www/ReactDOM-prod.modern.js	=	557.43 kB	557.40 kB	=	98.10 kB	98.09 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against bdf6467

sebmarkbage

It's also faster since concating would create a new string rope and potentially have to copy/rehash. Where as the same interned instance of the string can be used otherwise.

Uses a safer strategy to track the last precedence to avoid the need to consistently remember to preprend `'p'` to the precedence value DiffTrain build for [1c958aa](1c958aa)

Uses a safer strategy to track the last precedence to avoid the need to consistently remember to preprend `'p'` to the precedence value

…8110) Uses a safer strategy to track the last precedence to avoid the need to consistently remember to preprend `'p'` to the precedence value

Uses a safer strategy to track the last precedence to avoid the need to consistently remember to preprend `'p'` to the precedence value DiffTrain build for commit 1c958aa.

Uses a safer strategy to track the last precedence to avoid the need …

bdf6467

…to consistently remember to preprend 'p' to the precedence value

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 26, 2024

sebmarkbage approved these changes Jan 26, 2024

View reviewed changes

gnoff merged commit 1c958aa into facebook:main Jan 30, 2024
36 checks passed

gnoff deleted the fix-precedence-keys branch January 30, 2024 18:10

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

gaearon pushed a commit that referenced this pull request Feb 3, 2024

[Fiber] Use a safer strategy to track the last precedence (#28110)

a47225b

Uses a safer strategy to track the last precedence to avoid the need to consistently remember to preprend `'p'` to the precedence value

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fiber] Use a safer strategy to track the last precedence #28110

[Fiber] Use a safer strategy to track the last precedence #28110

gnoff commented Jan 26, 2024

react-sizebot commented Jan 26, 2024

sebmarkbage left a comment

[Fiber] Use a safer strategy to track the last precedence #28110

[Fiber] Use a safer strategy to track the last precedence #28110

Conversation

gnoff commented Jan 26, 2024

react-sizebot commented Jan 26, 2024

Critical size changes

Significant size changes

sebmarkbage left a comment

Choose a reason for hiding this comment