Add flag to disable caching behavior of `React.cache` on the client #28250

gnoff · 2024-02-05T22:27:21Z

Adds a feature flag to control whether the client cache function is just a passthrough. before we land breaking changes for the next major it will be off and then we can flag it on when we want to break it.

flag is off for OSS for now and on elsewhere (though the parent flag enableCache is off in some cases)

…ust a passthrough. before we land breaking chagnes for the next major it will be off and then we can flag it on when we want to break it.

react-sizebot · 2024-02-05T22:33:42Z

Comparing: 596827f...e88d439

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	591.32 kB	591.32 kB	=	104.34 kB	104.34 kB
facebook-www/ReactDOM-prod.modern.js	=	575.08 kB	575.08 kB	=	101.43 kB	101.43 kB
oss-stable-semver/react/cjs/react.production.min.js	+8.25%	7.51 kB	8.13 kB	+7.99%	2.89 kB	3.12 kB
oss-stable/react/cjs/react.production.min.js	+8.22%	7.54 kB	8.16 kB	+7.88%	2.92 kB	3.15 kB
oss-experimental/react/cjs/react.production.min.js	+6.84%	9.01 kB	9.63 kB	+6.36%	3.37 kB	3.58 kB
oss-stable-semver/react/cjs/react.production.js	+6.14%	32.48 kB	34.48 kB	+3.75%	9.29 kB	9.63 kB
oss-stable/react/cjs/react.production.js	+6.14%	32.51 kB	34.51 kB	+3.74%	9.32 kB	9.67 kB
oss-stable-semver/react/umd/react.profiling.min.js	+5.52%	11.30 kB	11.93 kB	+5.38%	4.43 kB	4.66 kB
oss-stable-semver/react/umd/react.production.min.js	+5.52%	11.31 kB	11.93 kB	+5.38%	4.43 kB	4.66 kB
oss-stable/react/umd/react.profiling.min.js	+5.51%	11.33 kB	11.95 kB	+5.32%	4.45 kB	4.69 kB
oss-stable/react/umd/react.production.min.js	+5.51%	11.33 kB	11.96 kB	+5.35%	4.45 kB	4.69 kB
oss-experimental/react/cjs/react.production.js	+5.38%	37.13 kB	39.12 kB	+3.25%	10.30 kB	10.63 kB
oss-experimental/react/umd/react.profiling.min.js	+4.84%	12.75 kB	13.36 kB	+4.91%	4.89 kB	5.13 kB
oss-experimental/react/umd/react.production.min.js	+4.84%	12.75 kB	13.36 kB	+4.89%	4.89 kB	5.13 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable-semver/react/cjs/react.production.min.js	+8.25%	7.51 kB	8.13 kB	+7.99%	2.89 kB	3.12 kB
oss-stable/react/cjs/react.production.min.js	+8.22%	7.54 kB	8.16 kB	+7.88%	2.92 kB	3.15 kB
oss-experimental/react/cjs/react.production.min.js	+6.84%	9.01 kB	9.63 kB	+6.36%	3.37 kB	3.58 kB
oss-stable-semver/react/cjs/react.production.js	+6.14%	32.48 kB	34.48 kB	+3.75%	9.29 kB	9.63 kB
oss-stable/react/cjs/react.production.js	+6.14%	32.51 kB	34.51 kB	+3.74%	9.32 kB	9.67 kB
oss-stable-semver/react/umd/react.profiling.min.js	+5.52%	11.30 kB	11.93 kB	+5.38%	4.43 kB	4.66 kB
oss-stable-semver/react/umd/react.production.min.js	+5.52%	11.31 kB	11.93 kB	+5.38%	4.43 kB	4.66 kB
oss-stable/react/umd/react.profiling.min.js	+5.51%	11.33 kB	11.95 kB	+5.32%	4.45 kB	4.69 kB
oss-stable/react/umd/react.production.min.js	+5.51%	11.33 kB	11.96 kB	+5.35%	4.45 kB	4.69 kB
oss-experimental/react/cjs/react.production.js	+5.38%	37.13 kB	39.12 kB	+3.25%	10.30 kB	10.63 kB
oss-experimental/react/umd/react.profiling.min.js	+4.84%	12.75 kB	13.36 kB	+4.91%	4.89 kB	5.13 kB
oss-experimental/react/umd/react.production.min.js	+4.84%	12.75 kB	13.36 kB	+4.89%	4.89 kB	5.13 kB
oss-stable-semver/react/cjs/react.development.js	+1.97%	99.87 kB	101.84 kB	+1.36%	26.90 kB	27.27 kB
oss-stable/react/cjs/react.development.js	+1.97%	99.89 kB	101.86 kB	+1.36%	26.93 kB	27.30 kB
oss-experimental/react/cjs/react.development.js	+1.87%	105.28 kB	107.25 kB	+1.18%	28.12 kB	28.46 kB
oss-stable-semver/react/umd/react.development.js	+1.72%	122.81 kB	124.92 kB	+1.29%	31.57 kB	31.97 kB
oss-stable/react/umd/react.development.js	+1.72%	122.83 kB	124.95 kB	+1.29%	31.60 kB	32.00 kB
oss-experimental/react/umd/react.development.js	+1.65%	128.55 kB	130.67 kB	+1.16%	32.85 kB	33.23 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against e88d439

acdlite

I think it would also work if you kept it in the same module (the first step is that Rollup inlines everything into one big module, anyway) but as long as sizebot is happy then I'm happy.

…28250) Adds a feature flag to control whether the client cache function is just a passthrough. before we land breaking changes for the next major it will be off and then we can flag it on when we want to break it. flag is off for OSS for now and on elsewhere (though the parent flag enableCache is off in some cases) DiffTrain build for [2bc7d33](2bc7d33)

rickhanlonii · 2024-02-06T04:23:57Z

packages/shared/ReactFeatureFlags.js

@@ -164,6 +164,9 @@ export const enableCustomElementPropertySupport = __NEXT_MAJOR__;
 // request for certain browsers.
 export const enableFilterEmptyStringAttributesDOM = __NEXT_MAJOR__;

+// Disabled caching behavior of `react/cache` in client runtimes.
+export const disableClientCache = false;


Any harm to enabling this in experimental now and setting it to __NEXT_MAJOR__?

…acebook#28250) Adds a feature flag to control whether the client cache function is just a passthrough. before we land breaking changes for the next major it will be off and then we can flag it on when we want to break it. flag is off for OSS for now and on elsewhere (though the parent flag enableCache is off in some cases)

…28250) Adds a feature flag to control whether the client cache function is just a passthrough. before we land breaking changes for the next major it will be off and then we can flag it on when we want to break it. flag is off for OSS for now and on elsewhere (though the parent flag enableCache is off in some cases) DiffTrain build for commit 2bc7d33.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 5, 2024

Adds a feature flag to control whether the client cache function is j…

e88d439

…ust a passthrough. before we land breaking chagnes for the next major it will be off and then we can flag it on when we want to break it.

gnoff force-pushed the gate-client-cache branch from 488849d to e88d439 Compare February 5, 2024 22:29

gnoff requested a review from acdlite February 5, 2024 22:44

gnoff changed the title ~~A flag to control disabling of React.cache on the client~~ Add flag to disable caching behavior of React.cache on the client Feb 5, 2024

gnoff requested a review from sebmarkbage February 5, 2024 23:55

acdlite approved these changes Feb 6, 2024

View reviewed changes

gnoff merged commit 2bc7d33 into facebook:main Feb 6, 2024
36 checks passed

gnoff deleted the gate-client-cache branch February 6, 2024 00:32

gnoff mentioned this pull request Feb 6, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

rickhanlonii reviewed Feb 6, 2024

View reviewed changes

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add flag to disable caching behavior of `React.cache` on the client #28250

Add flag to disable caching behavior of `React.cache` on the client #28250

gnoff commented Feb 5, 2024

react-sizebot commented Feb 5, 2024

acdlite left a comment

rickhanlonii Feb 6, 2024

Add flag to disable caching behavior of React.cache on the client #28250

Add flag to disable caching behavior of React.cache on the client #28250

Conversation

gnoff commented Feb 5, 2024

react-sizebot commented Feb 5, 2024

Critical size changes

Significant size changes

acdlite left a comment

Choose a reason for hiding this comment

rickhanlonii Feb 6, 2024

Choose a reason for hiding this comment

Add flag to disable caching behavior of `React.cache` on the client #28250

Add flag to disable caching behavior of `React.cache` on the client #28250