Convert ReactRenderDocument to hydrateRoot #28153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
commented
Jan 30, 2024
| }, | ||
| }); | ||
| }); | ||
| }).toErrorDev( |
There was a problem hiding this comment.
These test have a bunch of improvements to the errors in the new root.
| // This creates an unfortunate double text case. | ||
| expect(container.textContent).toBe('potatoparsnip'); | ||
| expect(container.textContent).toBe('parsnip'); |
There was a problem hiding this comment.
Client render replaces the content with the client version.
| } | ||
| expect(testDocument.body.innerHTML).toBe('Hello world'); | ||
| }); | ||
|
|
||
| it('supports findDOMNode on full-page components', () => { | ||
| it('supports findDOMNode on full-page components in legacy mode', () => { |
There was a problem hiding this comment.
Specifically testing findDOMNode.
|
Comparing: 4d6c47b...da2c623 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Seems like www is not happy with the new tests. |
eps1lon
approved these changes
Feb 7, 2024
|
Thanks for the fix @eps1lon! |
huozhi
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 9, 2024
Updates React from 2bc7d336a to ba5e6a832. ### React upstream changes - facebook/react#28283 - facebook/react#28280 - facebook/react#28079 - facebook/react#28233 - facebook/react#28276 - facebook/react#28272 - facebook/react#28265 - facebook/react#28259 - facebook/react#28153 - facebook/react#28246 - facebook/react#28218 - facebook/react#28263 - facebook/react#28257 - facebook/react#28261 - facebook/react#28262 - facebook/react#28260 - facebook/react#28258 - facebook/react#27864 - facebook/react#28254 - facebook/react#28219 - facebook/react#28248 - facebook/react#28216 - facebook/react#28249 - facebook/react#28241 - facebook/react#28243 - facebook/react#28253 - facebook/react#28256 - facebook/react#28236 - facebook/react#28237 - facebook/react#28242 - facebook/react#28251 - facebook/react#28252 Closes NEXT-2411
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Sebastian Silbermann <sebastian.silbermann@klarna.com>
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
Co-authored-by: Sebastian Silbermann <sebastian.silbermann@klarna.com> DiffTrain build for commit 2cd19ed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.