Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete more redundant JSX code #28276

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Feb 8, 2024

Found another redundant implementation of JSX code. Not being used anywhere so safe to delete.

Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 8, 2024
Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)

@react-sizebot
Copy link

Comparing: 37d901e...3bae73d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.64 kB 176.64 kB = 55.02 kB 55.02 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.63 kB 178.63 kB = 55.60 kB 55.59 kB
facebook-www/ReactDOM-prod.classic.js = 591.73 kB 591.73 kB = 104.44 kB 104.44 kB
facebook-www/ReactDOM-prod.modern.js = 575.51 kB 575.51 kB = 101.53 kB 101.53 kB
test_utils/ReactAllWarnings.js Deleted 67.02 kB 0.00 kB Deleted 16.42 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 67.02 kB 0.00 kB Deleted 16.42 kB 0.00 kB

Generated by 🚫 dangerJS against 3bae73d

@acdlite acdlite merged commit d3def47 into facebook:main Feb 8, 2024
36 checks passed
@acdlite
Copy link
Collaborator Author

acdlite commented Feb 8, 2024

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)

yeah same :) I'm going to keep trying to consolidate it more.

github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.

DiffTrain build for [d3def47](d3def47)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.

DiffTrain build for commit d3def47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants