Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler][test fixtures] Add enablePropagateDepsInHIR to forked tests #31031

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[compiler][test fixtures] Add enablePropagateDepsInHIR to forked tests #31031

merged 2 commits into from
Sep 30, 2024

Conversation

mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Sep 23, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Annotates fixtures added in #31030 with @enablePropagateDepsInHIR to fork behavior (and commit snapshot differences)

@mofeiZ
Update
36c068c 
[ghstack-poisoned]
@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 4:39pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 23, 2024
This was referenced Sep 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mofeiZ mofeiZ changed the title [compiler][test fixtures] Add @enablePropagateDepsInHIR to forked tests [compiler][test fixtures] Add enablePropagateDepsInHIR to forked tests Sep 25, 2024
@mofeiZ mofeiZ marked this pull request as ready for review September 25, 2024 22:57
@mofeiZ mofeiZ mentioned this pull request Sep 25, 2024
Merged
mvitousek
mvitousek approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@mvitousek mvitousek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@mofeiZ mofeiZ mentioned this pull request Sep 26, 2024
Merged
@mofeiZ
Update
078335d 
[ghstack-poisoned]
@mofeiZ mofeiZ merged commit 078335d into gh/mofeiZ/16/base Sep 30, 2024
19 of 20 checks passed
mofeiZ added a commit that referenced this pull request Sep 30, 2024
@mofeiZ
[compiler][test fixtures] Add enablePropagateDepsInHIR to forked tests
1a77920 
Annotates fixtures added in #31030 with `@enablePropagateDepsInHIR` to fork behavior (and commit snapshot differences)
ghstack-source-id: e423e8c42db62f1bb87562b770761be09fc8ffc6
Pull Request resolved: #31031
@mofeiZ mofeiZ deleted the gh/mofeiZ/16/head branch September 30, 2024 16:35
This was referenced Oct 1, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvitousek mvitousek mvitousek approved these changes

@josephsavona josephsavona josephsavona approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mofeiZ @mvitousek @josephsavona @facebook-github-bot