[compiler][hir-rewrite] Check mutability of base identifier when hoisting #31032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Sep 23, 2024
This was referenced Sep 23, 2024
facebook-github-bot
added
the
React Core Team
This was referenced Sep 25, 2024
[ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Sep 30, 2024
Followup from #30894 , not sure how these got missed. Note that this PR just copies the fixtures without adding `@enablePropagateDepsInHIR`. #31032 follows and actually enables the HIR-version of propagateScopeDeps to run. I split this out into two PRs to make snapshot differences easier to review, but also happy to merge Fixtures found from locally setting snap test runner to default to `enablePropagateDepsInHIR: 'enabled_baseline'` and forking fixtures files with different output. ghstack-source-id: 7d7cf41aa923d83ad49f89079171b0411923ce6b Pull Request resolved: #31030
[ghstack-poisoned]
[ghstack-poisoned]
mofeiZ
commented
Oct 1, 2024
Comment on lines
+3
to
+16
| /** | ||
| * Not safe to hoist read of maybeNullObject.value.inner outside of the | ||
| * try-catch block, as that might throw | ||
| */ | ||
| function useFoo(maybeNullObject: {value: {inner: number}} | null) { | ||
| const y = []; | ||
| try { | ||
| y.push(identity(maybeNullObject.value.inner)); | ||
| } catch { | ||
| y.push('null'); | ||
| } | ||
|
|
||
| return y; | ||
| } |
There was a problem hiding this comment.
Bug repro is unrelated to this fix
mofeiZ
commented
Oct 1, 2024
| let x; | ||
| if ($[0] !== props) { | ||
| if ($[0] !== props.y || $[1] !== props.e) { |
There was a problem hiding this comment.
Note that we're now inferring props as non-mutable. Previously, props.y was not marked hoistable because the evaluation of LoadLocal props had a mutable range (due to the try-catch).
[ghstack-poisoned]
josephsavona
approved these changes
Oct 1, 2024
[ghstack-poisoned]
[ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Oct 3, 2024
…n decls (#31066) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #31066 * #31032 Prior to this PR, we consider all of a nested function's accessed paths as 'hoistable' (to the basic block in which the function was defined). Now, we traverse nested functions and find all paths hoistable to their *entry block*. Note that this only replaces the *hoisting* part of function declarations, not dependencies. This realistically only affects optional chains within functions, which always get truncated to its inner non-optional path (see [todo-infer-function-uncond-optionals-hoisted.tsx](https://github.com/facebook/react/blob/576f3c0aa898cb99da1b7bf15317756e25c13708/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/propagate-scope-deps-hir-fork/reduce-reactive-deps/todo-infer-function-uncond-optionals-hoisted.tsx)) See newly added test fixtures for details Update: Note that toggling `enableTreatFunctionDepsAsConditional` makes a non-trivial impact on granularity of inferred deps (i.e. we find that function declarations uniquely identify some paths as hoistable). Snapshot comparison of internal code shows ~2.5% of files get worse dependencies ([internal link](https://www.internalfb.com/phabricator/paste/view/P1625792186))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Prior to this PR, we check whether the property load source (e.g. the evaluation of
<base>in<base>.property) is mutable + scoped to determine whether the property load itself is eligible for hoisting. This changes to check the base identifier of the load.