Fix issue where we were not centering absolute nodes correctly when justifying #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51383625 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
|
This pull request was exported from Phabricator. Differential Revision: D51383625 |
joevilches
force-pushed
the
export-D51383625
branch
from
05bc3d5
to
dc0f33d
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
…ustifying (facebook#1489) Summary: Pull Request resolved: facebook#1489 X-link: facebook/react-native#41690 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625 fbshipit-source-id: 234f6f0984217db26387ddef79fc4b2f8ba969f6
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
|
This pull request was exported from Phabricator. Differential Revision: D51383625 |
joevilches
force-pushed
the
export-D51383625
branch
from
dc0f33d
to
4ce96fd
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…ustifying (facebook#1489) Summary: Pull Request resolved: facebook#1489 X-link: facebook/react-native#41690 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625 fbshipit-source-id: 129388409ffcf35e8c8c840f6fdb1daed748efc1
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 6, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 6, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 6, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
|
This pull request was exported from Phabricator. Differential Revision: D51383625 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 6, 2023
…ustifying (facebook#1489) Summary: Pull Request resolved: facebook#1489 X-link: facebook/react-native#41690 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625 fbshipit-source-id: 68a55f3a690204eeb3ab495272a5f6bf0a35516b
joevilches
force-pushed
the
export-D51383625
branch
from
4ce96fd
to
4192598
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 6, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
|
This pull request was exported from Phabricator. Differential Revision: D51383625 |
joevilches
force-pushed
the
export-D51383625
branch
from
4192598
to
e776529
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 6, 2023
…ustifying (facebook#1489) Summary: Pull Request resolved: facebook#1489 X-link: facebook/react-native#41690 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625 fbshipit-source-id: 54d33bbe10ac5a551e139f5aaca4ee6cd7f9018d
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 6, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
|
This pull request was exported from Phabricator. Differential Revision: D51383625 |
joevilches
force-pushed
the
export-D51383625
branch
from
e776529
to
4109b38
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
|
This pull request was exported from Phabricator. Differential Revision: D51383625 |
joevilches
force-pushed
the
export-D51383625
branch
from
a901cfc
to
953e306
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#1489) Summary: Pull Request resolved: facebook#1489 X-link: facebook/react-native#41690 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625 fbshipit-source-id: 2a0a45aaf73949bfdc8daa1721f78eadaa7715ff
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625
…ng absolute node's position Summary: Absolute nodes can be laid out by themselves and do not have to care about what is happening to their siblings. Because of this we can make `positionAbsoluteChild` the sole place where we handle this logic. Right now that is scattered around algorithm with many `if (child is absolute)` cases everywhere. This makes implementing position static a lot harder since we are relying on the CB to do all this work, not the parent. With this change the only time we set position for an absolute node and it matter (i.e. not overwritten) is in `positionAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51290723 fbshipit-source-id: 2b88199d938bb0145eb492a9718ba2a57fee2c7f
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: 6837a5e6057f0bbce401f91c23989f5bc602800d
…ox (facebook#1485) Summary: Pull Request resolved: facebook#1485 X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Differential Revision: https://www.internalfb.com/diff/D51330526?entry_point=27 fbshipit-source-id: 432d878ceecd9ff8dad16a6751a98a2d9b803037
Differential Revision: https://www.internalfb.com/diff/D51333812?entry_point=27 fbshipit-source-id: 5aff8bec70bcb0870424dfe0ce98db41456b7aa2
Summary: Tsia. Added test and accounted for parent padding Differential Revision: https://www.internalfb.com/diff/D51374086?entry_point=27 fbshipit-source-id: b3e67c5c27e8d1abb65aa81df3a3835f153300d4
…rtain case Differential Revision: https://www.internalfb.com/diff/D51376309?entry_point=27 fbshipit-source-id: 57e8c2a79fa1503e5969b5c26329bd425d88abb8
…ustifying (facebook#1489) Summary: Pull Request resolved: facebook#1489 X-link: facebook/react-native#41690 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625 fbshipit-source-id: 9fc4507a79aa418489aa9beba09e7f64701bfb5e
|
This pull request was exported from Phabricator. Differential Revision: D51383625 |
joevilches
force-pushed
the
export-D51383625
branch
from
953e306
to
a666120
Compare
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 8, 2023
…ustifying Summary: X-link: facebook/yoga#1489 X-link: facebook/react-native#41690 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625 fbshipit-source-id: 6bbbace95689ef39c35303bea4b99505952df457
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 8, 2023
…ustifying (#41690) Summary: X-link: facebook/yoga#1489 Pull Request resolved: #41690 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625 fbshipit-source-id: 6bbbace95689ef39c35303bea4b99505952df457
|
This pull request has been merged in 897f9b7. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…ustifying (facebook#41690) Summary: X-link: facebook/yoga#1489 Pull Request resolved: facebook#41690 Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child Reviewed By: NickGerleman Differential Revision: D51383625 fbshipit-source-id: 6bbbace95689ef39c35303bea4b99505952df457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#41690
Centering involves centering the margin box in the content box of the parent, and then getting the distance from the flex start edge of the parent to the child
Reviewed By: NickGerleman
Differential Revision: D51383625