Add 'Reconnect DevTools' toolbar button #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a simple toolbar button to
This is most useful when the "disconnected" dialog is dismissed, e.g. to inspect existing logs.
Originally suggested by @rubennorte via T192737861
Test plan
Trigger a disconnection, e.g. terminate Metro, terminate the target app, etc.
Upstreaming plan
This PR is upstream-able in principle. However, a more sophisticated mechanism to check and display connection status could be Fusebox-specific in the future, e.g. a ping/pong mechanism directly to the target: EdmondChuiHW@8234bce
devtools-frontend
repo. I've reviewed the contribution guide.