Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Reconnect DevTools' toolbar button #85

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Add 'Reconnect DevTools' toolbar button #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions front_end/entrypoints/rn_fusebox/rn_fusebox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@ const UIStrings = {
*@description Label of the FB-only 'send feedback' action button in the toolbar
*/
sendFeedback: '[FB-only] Send feedback',
/**
*@description Tooltip of the connection status toolbar button while disconnected
*/
connectionStatusDisconnectedTooltip: 'Debugging connection was closed',
/**
*@description Button label of the connection status toolbar button while disconnected
*/
connectionStatusDisconnectedLabel: 'Reconnect DevTools',
};
const str_ = i18n.i18n.registerUIStrings('entrypoints/rn_fusebox/rn_fusebox.ts', UIStrings);
const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
Expand Down Expand Up @@ -171,4 +179,47 @@ if (globalThis.FB_ONLY__reactNativeFeedbackLink) {
});
}

class ConnectionStatusToolbarItemProvider extends SDK.TargetManager.Observer implements UI.Toolbar.Provider {
#button = new UI.Toolbar.ToolbarButton('');

constructor() {
super();
this.#button.setVisible(false);
this.#button.element.classList.add('fusebox-connection-status');
this.#button.addEventListener(UI.Toolbar.ToolbarButton.Events.Click, this.onClick.bind(this));

SDK.TargetManager.TargetManager.instance().observeTargets(this, {scoped: true});
}

override targetAdded(_target: SDK.Target.Target): void {
this.#updateRootTarget();
}
override targetRemoved(_target: SDK.Target.Target): void {
this.#updateRootTarget();
}

#updateRootTarget(): void {
const rootTarget = SDK.TargetManager.TargetManager.instance().rootTarget();
this.#button.setTitle(i18nLazyString(UIStrings.connectionStatusDisconnectedTooltip)());
this.#button.setText(i18nLazyString(UIStrings.connectionStatusDisconnectedLabel)());
this.#button.setVisible(!rootTarget);
}

onClick(): void {
window.location.reload();
}

item(): UI.Toolbar.ToolbarItem {
return this.#button;
}
}

const connectionStatusToolbarItemProvider = new ConnectionStatusToolbarItemProvider();
UI.Toolbar.registerToolbarItem({
location: UI.Toolbar.ToolbarItemLocation.MAIN_TOOLBAR_RIGHT,
loadItem: async () => {
return connectionStatusToolbarItemProvider;
},
});

Host.rnPerfMetrics.entryPointLoadingFinished('rn_fusebox');
19 changes: 19 additions & 0 deletions front_end/ui/legacy/toolbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,3 +581,22 @@ devtools-icon.leading-issue-icon {
[aria-label="[FB-only] Send feedback"] .toolbar-glyph {
color: white !important;
}

/* [RN] Customise styling for Fusebox's connection status button */

.fusebox-connection-status {
margin: 4px;
height: 20px;
padding: 0 4px;
border-radius: 4px;
background: color-mix(in srgb, var(--color-red) 80%, transparent);
}

.fusebox-connection-status:hover {
background: color-mix(in srgb, var(--color-red) 90%, transparent);
}

.fusebox-connection-status .toolbar-text,
.fusebox-connection-status .toolbar-glyph {
color: white !important;
}
Loading