Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lower the supported NodeJS version from 18 or greater to only 18 #485

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

JakeChampion
Copy link
Contributor

Node 19 is not supported by tree-sitter yet, and that is a dependency of ours. Until tree-sitter works on Node 19, we should not list Node 19 as supported.

Node 19 is [not supported by tree-sitter yet](tree-sitter/node-tree-sitter#127), and that is a dependency of ours. Until tree-sitter works on Node 19, we should not list Node 19 as supported.
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JakeChampion JakeChampion merged commit 5cc1cd6 into main Apr 11, 2023
@JakeChampion JakeChampion deleted the jake/node-version branch April 11, 2023 16:53
@guybedford
Copy link
Member

Hmm, this is a serious issue - can we maybe move to another parser that supports it? Node.js 20 goes out this month and that will be very important to support.

@JakeChampion
Copy link
Contributor Author

Hmm, this is a serious issue - can we maybe move to another parser that supports it? Node.js 20 goes out this month and that will be very important to support.

We can probably fork and patch with the linked PR to bring support on for newer Node versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants