Support Node 19 and 20 #127

verhovsky · 2023-03-09T08:08:11Z

and also update the dependencies.

Closes #126 , closes #90 and closes tree-sitter/tree-sitter#1945 (which should have been opened on this repo)

verhovsky · 2023-03-09T08:10:18Z

package.json

+    "mocha": "^10.2.0",
+    "node-gyp": "9.3.1",
+    "prebuild": "^11.0.4",
+    "superstring": "https://github.com/pulsar-edit/superstring#node-api-upgrade",


This is not great. superstring is deprecated and it has the same issue that it uses the same V8 functions that don't exist anymore. The changes in this fork were proposed upstream atom/superstring#94 but they're not going to get merged of course. Can we remove superstring as a tree-sitter dependency?

We could also fork and publish as @tree-sitter/superstring

Actually, since superstring is in devDependencies, we shouldn't strictly need to fix it to make tree-sitter installable on Node 19 or 20, so I undid this change.

verhovsky · 2023-03-09T08:11:26Z

package.json

+    "@types/node": "^18.14.6",
+    "chai": "^4.3.7",
+    "mocha": "^10.2.0",
+    "node-gyp": "9.3.1",


This isn't strictly necessary but it lets you run the project with Python 3.11

See prebuild/prebuild#286 (comment)

verhovsky · 2023-03-09T08:17:45Z

With these changes I was able to npm install on macOS (ARM) with Node 14 and Node 18, although npm test errors out with

RangeError: Incompatible language version. Compatible range: 13 - 13. Got: 14

verhovsky · 2023-03-09T08:44:33Z

After updating vendor/tree-sitter I'm able to run npm test too.

verhovsky · 2023-03-09T11:40:24Z

I couldn't figure out how to fix the CI with Windows, the last thing I tried is setting the Node version to 16 and it failed to download node to install it

npm ERR! gyp ERR! stack Error: 500 response downloading https://nodejs.org/download/release/v16.18.1/node-v16.18.1-headers.tar.gz

So I replaced the Windows with Ubuntu instead in the CI and it works... anyway, we should test Windows with #128

verhovsky · 2023-03-09T23:12:59Z

src/conversions.cc

@@ -34,7 +34,7 @@ void InitConversions(Local<Object> exports) {
    v8::Local<v8::Object> bufferView;
    bufferView = node::Buffer::New(Isolate::GetCurrent(), point_transfer_buffer, 0, 2 * sizeof(uint32_t)).ToLocalChecked();
    auto js_point_transfer_buffer = node::Buffer::Data(bufferView);
-  #elif V8_MAJOR_VERSION >= 8
+  #elif (V8_MAJOR_VERSION > 8 || (V8_MAJOR_VERSION == 8 && V8_MINOR_VERION > 3))


Introduced in 8.3.9 v8/v8@5cf02f0

jgresty · 2023-03-16T13:20:30Z

Keen to have this merged as the currently used version of prebuild-install is vulnerable to CVE-2021-3807 through its dependencies. Fixed in 7.1.1

Node 19 is [not supported by tree-sitter yet](tree-sitter/node-tree-sitter#127), and that is a dependency of `@fastly/js-compute`. Until tree-sitter works on Node 19, we should not list Node 19 as supported.

Node 19 is [not supported by tree-sitter yet](tree-sitter/node-tree-sitter#127), and that is a dependency of ours. Until tree-sitter works on Node 19, we should not list Node 19 as supported.

Node 19 is [not supported by tree-sitter yet](tree-sitter/node-tree-sitter#127), and that is a dependency of `@fastly/js-compute`. Until tree-sitter works on Node 19, we should not list Node 19 as supported.

jaisnan · 2023-05-02T16:44:55Z

Is there any reason this isn't merged yet?

NikkTod · 2023-06-01T11:43:00Z

Could you please merge 👍

cclauss · 2023-06-01T12:33:55Z

@NikkTod Please

Click on https://github.com/tree-sitter/node-tree-sitter/pull/127/files
Click the Review changes button
Click Approve
Click Submit review.

tthornton3-chwy · 2023-06-01T14:51:27Z

@verhovsky thanks so much for working on this! looks like we got the approvals :) Could we try and merge this in, this dependency trickles its way on up to a bunch of other places that are currently borked because of it after moving to Node 20, and fixing it here at the source is a lot better of a solution :D

TylerLeonhardt · 2023-06-07T16:31:01Z

👋 I think maybe @maxbrunsfeld is maybe the best person to (gently) ping? I'm coming from this tree-sitter-typescript issue. Would love to see Node 19+ working with node-tree-sitter 🙏 so folks can build VS Code extensions with newer versions of Node.

verhovsky · 2023-06-14T15:55:35Z

src/tree.cc

@@ -196,7 +196,7 @@ void Tree::GetEditedRange(const Nan::FunctionCallbackInfo<Value> &info) {

 void Tree::PrintDotGraph(const Nan::FunctionCallbackInfo<Value> &info) {
  Tree *tree = ObjectWrap::Unwrap<Tree>(info.This());
-  ts_tree_print_dot_graph(tree->tree_, stderr);
+  ts_tree_print_dot_graph(tree->tree_, 2);


This happens because of updating vendor/tree-sitter:

../src/tree.cc:199:3: error: no matching function for call to 'ts_tree_print_dot_graph' ts_tree_print_dot_graph(tree->tree_, stderr); ^~~~~~~~~~~~~~~~~~~~~~~ ../vendor/tree-sitter/lib/include/tree_sitter/api.h:423:6: note: candidate function not viable: no known conversion from 'FILE *' (aka '__sFILE *') to 'int' for 2nd argument void ts_tree_print_dot_graph(const TSTree *, int file_descriptor); ^

introduced in tree-sitter/tree-sitter@97fd990

cclauss · 2023-06-15T08:59:12Z

Please change the title of this PR to add 18 and remove 19 which is EOL.

https://github.com/nodejs/release#readme

verhovsky · 2023-06-15T12:51:39Z

I split this PR into separate commits: #134 #140 #141 #142

Support Node 19 and update dependencies

45f2b88

verhovsky commented Mar 9, 2023

View reviewed changes

Update tree-sitter to latest commit

74ca3b3

verhovsky added 3 commits March 9, 2023 09:50

prebuild modern versions of Electron/Node

df27b82

BackingStore::EmptyDeleter doesn't exist on V8 v8

4cece9f

Add older Electron/Node versions

ca59027

verhovsky force-pushed the node-19 branch 6 times, most recently from afa680a to 8973bd6 Compare March 9, 2023 11:33

Replace Windows with Ubuntu in CI

d9c50a7

verhovsky force-pushed the node-19 branch from 8973bd6 to d9c50a7 Compare March 9, 2023 11:37

verhovsky mentioned this pull request Mar 9, 2023

Convert module to use NAPI instead of Nan #52

Closed

BackingStore::EmptyDeleter was added in v8 8.3

6981496

verhovsky commented Mar 9, 2023

View reviewed changes

rien mentioned this pull request Mar 14, 2023

Installation failure with tree-sitter for Node 19: no member named Creationcontext dodona-edu/dolos#1073

Open

This comment was marked as outdated.

Sign in to view

cclauss approved these changes Mar 19, 2023

View reviewed changes

cclauss mentioned this pull request Mar 19, 2023

GitHub Action to do npm ci ; npm test #132

Closed

verhovsky mentioned this pull request Mar 26, 2023

Replace AppVeyor with GitHub Actions #128

Merged

verhovsky mentioned this pull request Apr 9, 2023

Node 19 npm install error tree-sitter/tree-sitter#1945

Closed

JakeChampion mentioned this pull request Apr 11, 2023

Lower the supported NodeJS version from 18 or greater to only 18 fastly/compute-starter-kit-javascript-default#41

Merged

JakeChampion mentioned this pull request Apr 11, 2023

dont declare an engines field and rely on the engines field from dependencies fastly/compute-starter-kit-javascript-expressly#5

Merged

This was referenced Apr 11, 2023

Lower the supported NodeJS version from 18 or greater to only 18 fastly/compute-starter-kit-javascript-queue#6

Merged

dont declare an engines field and rely on the engines field from dependencies fastly/compute-starter-kit-javascript-empty#12

Merged

JakeChampion mentioned this pull request Apr 11, 2023

fix: Lower the supported NodeJS version from 18 or greater to only 18 fastly/js-compute-runtime#485

Merged

verhovsky mentioned this pull request Apr 11, 2023

Make code compilable on Node 19 #134

Merged

Prebuild for Node 20

1d0e677

verhovsky changed the title ~~Support Node 19 and update dependencies~~ Support Node 19 and 20 May 2, 2023

Keep old superstring

1af94ba

verhovsky mentioned this pull request May 3, 2023

prebuild-install should be in package.json's dev dependencies #135

Closed

This was referenced May 25, 2023

Cucumber.io doesn't work properly on VS Code v1.78.2 cucumber/vscode#164

Closed

Failure to start extension under latest VS Code cucumber/vscode#155

Closed

NikkTod approved these changes Jun 1, 2023

View reviewed changes

hendrikvanantwerpen mentioned this pull request Jun 7, 2023

Error: bad export type for tree_sitter_typescript_external_scanner_create: undefined tree-sitter/tree-sitter-typescript#244

Closed

char0n mentioned this pull request Jun 14, 2023

Use Node.js 20.3.0 as dev/CI Node.js version swagger-api/apidom#2851

Closed

verhovsky commented Jun 14, 2023

View reviewed changes

verhovsky closed this Jun 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Node 19 and 20 #127

Support Node 19 and 20 #127

verhovsky commented Mar 9, 2023 •

edited

Loading

verhovsky Mar 9, 2023 •

edited

Loading

verhovsky Mar 9, 2023 •

edited

Loading

verhovsky May 2, 2023 •

edited

Loading

verhovsky Mar 9, 2023

verhovsky commented Mar 9, 2023

verhovsky commented Mar 9, 2023

verhovsky commented Mar 9, 2023

verhovsky Mar 9, 2023

jgresty commented Mar 16, 2023

This comment was marked as outdated.

jaisnan commented May 2, 2023

NikkTod commented Jun 1, 2023

cclauss commented Jun 1, 2023

tthornton3-chwy commented Jun 1, 2023 •

edited

Loading

TylerLeonhardt commented Jun 7, 2023

verhovsky Jun 14, 2023

cclauss commented Jun 15, 2023

verhovsky commented Jun 15, 2023

Support Node 19 and 20 #127

Support Node 19 and 20 #127

Conversation

verhovsky commented Mar 9, 2023 • edited Loading

verhovsky Mar 9, 2023 • edited Loading

Choose a reason for hiding this comment

verhovsky Mar 9, 2023 • edited Loading

Choose a reason for hiding this comment

verhovsky May 2, 2023 • edited Loading

Choose a reason for hiding this comment

verhovsky Mar 9, 2023

Choose a reason for hiding this comment

verhovsky commented Mar 9, 2023

verhovsky commented Mar 9, 2023

verhovsky commented Mar 9, 2023

verhovsky Mar 9, 2023

Choose a reason for hiding this comment

jgresty commented Mar 16, 2023

This comment was marked as outdated.

jaisnan commented May 2, 2023

NikkTod commented Jun 1, 2023

cclauss commented Jun 1, 2023

tthornton3-chwy commented Jun 1, 2023 • edited Loading

TylerLeonhardt commented Jun 7, 2023

verhovsky Jun 14, 2023

Choose a reason for hiding this comment

cclauss commented Jun 15, 2023

verhovsky commented Jun 15, 2023

verhovsky commented Mar 9, 2023 •

edited

Loading

verhovsky Mar 9, 2023 •

edited

Loading

verhovsky Mar 9, 2023 •

edited

Loading

verhovsky May 2, 2023 •

edited

Loading

tthornton3-chwy commented Jun 1, 2023 •

edited

Loading