Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e, emulator): correctly detect emulator suite startup failure #6182

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

mikehardy
Copy link
Contributor

Description

Previously if this script failed it would just retry endlessly and fail a CI run.
Now it correctly determines startup failure and retries 3 times.
Emulator suite shuts itself down after 30 seconds if it didn't starts, determined by experience

Related Issues

invertase/react-native-firebase#5335

I'm always working in the background on de-flaking CI for react-native-firebase, this is porting some of that work here since the script is the same
invertase/react-native-firebase#4058 (comment)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@mikehardy
Copy link
Contributor Author

The failed check is formatting in dart code that this PR does not touch

Previously if this script failed it would just retry endlessly and fail a CI run.
Now it correctly determines startup failure and retries 3 times.
Emulator suite shuts itself down after 30 seconds if it didn't starts, determined by experience
@mikehardy mikehardy force-pushed the @mikehardy/emulator-startup branch from 7ce15c5 to 5fec4e3 Compare May 19, 2021 00:21
@mikehardy
Copy link
Contributor Author

(FWIW this new script has been through quite a few runs locally and in github actions in the react-native-firebase repo, looking good so far, and fewer flaky runs needing restarts!)

@Salakar Salakar merged commit 904b64f into firebase:master Jun 3, 2021
@firebase firebase locked and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants