Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): misc fixes: storage crashes, auth error messages, lint #5335

Merged
merged 4 commits into from
May 18, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

Lots of items picked off from #5324 as they were seen while in the area but were separate

Related issues

Fixes #3917 (I think, issue has a request for feedback already)
Fixes #4097

Release Summary

conventional commits - rebase merge

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Tested locally e2e on android (it's a batch of android fixes) and CI will check it


Think react-native-firebase is great? Please consider supporting the project with any of the below:

…reject

Previously if you sent undefined in as a URL, or a URL that was unparseable,
the native android code would throw IllegalArgumentException, which would crash
the app with a native exception. Now those exceptions are caught and bubbled up
to the javascript layer correctly as a promise rejection

Fixes #4097
Highlights:

- enforce CallSuper so TaskExecutors will always clean up correctly
- enforce Locale translation in string manipulaton (Fixes #3917)
@vercel
Copy link

vercel bot commented May 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/2RTcJmt3FFhX77PBhZL9yPGNFYmo
✅ Preview: https://react-native-firebase-git-mikehardy-misc-fixes-invertase.vercel.app

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #5335 (10f9099) into master (7a4f78e) will increase coverage by 6.65%.
The diff coverage is n/a.

❗ Current head 10f9099 differs from pull request most recent head 50bd106. Consider uploading reports for the commit 50bd106 to get more accurate results

@@             Coverage Diff              @@
##             master    #5335      +/-   ##
============================================
+ Coverage     68.90%   75.54%   +6.65%     
============================================
  Files           189       96      -93     
  Lines          9419     4218    -5201     
  Branches       1411      845     -566     
============================================
- Hits           6489     3186    -3303     
+ Misses         2494      963    -1531     
+ Partials        436       69     -367     

This was contributing to E2E flakiness, Related #4058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant