Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VA Fixes: USB IRQ Handling and EP configuration, Thread handler shenanigans. #3705

Merged
merged 9 commits into from
Jun 12, 2024
Merged

VA Fixes: USB IRQ Handling and EP configuration, Thread handler shenanigans. #3705

merged 9 commits into from
Jun 12, 2024

Conversation

skotopes
Copy link
Member

@skotopes skotopes commented Jun 12, 2024 •
edited
Loading

What's new

  • FuriHal: update max power in USB descriptors
  • Furi: drop task handle, cleanup casts and memory corrupt in threads
  • FuriHal: properly handle high priority USB IRQ, change CDC descriptor to use separate TX/RX endpoints fix USB: File writing hang regression for big files #3452

Verification

  • ps in CLI shouldn't cause crash anymore
  • Uni-direction and bi-directional endpoint should be correctly handled in all configuration
  • Fix NotImplemented crash on USB use

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

Compiled f7 firmware for commit a3fb6899:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

PVS-Studio report for commit 20842352:

hedger
hedger previously approved these changes Jun 12, 2024
View reviewed changes
hedger
hedger previously approved these changes Jun 12, 2024
View reviewed changes
@skotopes skotopes mentioned this pull request Jun 12, 2024
Closed
3 tasks
@DrZlo13 DrZlo13 merged commit 70d2453 into dev Jun 12, 2024
10 of 11 checks passed
@DrZlo13 DrZlo13 deleted the aku/usb_n_thread_fix branch June 12, 2024 15:07
@Willy-JL Willy-JL mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrZlo13 DrZlo13 DrZlo13 approved these changes

@hedger hedger hedger left review comments

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USB: File writing hang regression for big files
3 participants
@skotopes @hedger @DrZlo13