Don't require 'Enter' key to confirm link hint selection #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes Issue #1 - link selection requires Enter key confirmation
Without the Enter key confirmation, conflicts can occur between link hints such as 'A' and 'AS', so I pulled the hint generation algorithm from Vimium (https://github.com/philc/vimium) to generate the hint text. This required counting the total number of links ahead of time, which unfortunately creates a small bit of redundancy in the code.
I don't know what all the test cases are, but the behavior seems to be correct for me for all form inputs and links, with the possible exception of checkboxes.