Migrate select event to package:unified_analytics #7479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasyishak
changed the title
11 tasks
eliasyishak
commented
Apr 18, 2024
Comment on lines
+666
to
+689
| userApp: gtagEvent.user_app, | ||
| userBuild: gtagEvent.user_build, | ||
| userPlatform: gtagEvent.user_platform, | ||
| devtoolsPlatform: gtagEvent.devtools_platform, | ||
| devtoolsChrome: gtagEvent.devtools_chrome, | ||
| devtoolsVersion: gtagEvent.devtools_version, | ||
| ideLaunched: gtagEvent.ide_launched, | ||
| isExternalBuild: gtagEvent.is_external_build, | ||
| isEmbedded: gtagEvent.is_embedded, | ||
| ideLaunchedFeature: gtagEvent.ide_launched_feature, | ||
| g3Username: gtagEvent.g3_username, | ||
| uiDurationMicros: gtagEvent.ui_duration_micros, | ||
| rasterDurationMicros: gtagEvent.raster_duration_micros, | ||
| shaderCompilationDurationMicros: | ||
| gtagEvent.shader_compilation_duration_micros, | ||
| traceEventCount: gtagEvent.trace_event_count, | ||
| cpuSampleCount: gtagEvent.cpu_sample_count, | ||
| cpuStackDepth: gtagEvent.cpu_stack_depth, | ||
| heapDiffObjectsBefore: gtagEvent.heap_diff_objects_before, | ||
| heapDiffObjectsAfter: gtagEvent.heap_diff_objects_after, | ||
| heapObjectsTotal: gtagEvent.heap_objects_total, | ||
| rootSetCount: gtagEvent.root_set_count, | ||
| rowCount: gtagEvent.row_count, | ||
| inspectorTreeControllerId: gtagEvent.inspector_tree_controller_id, |
There was a problem hiding this comment.
Even though we include all of the possible fields, most of these are nullable and if they are null when passed to Event.fromJson, those fields won't get sent to GA4
kenzieschmoll
approved these changes
Apr 22, 2024
|
Will this PR also need a bump to the new unified_analytics version 6.1.0? |
|
Yep, once dart-lang/tools#258 merges and publishes i'll bump the version here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of tracker issue:
package:unified_analyticsfor analytics collection #7083Migrates the select analytics event to package:unified_analytics
EDIT: April 18
I have been able to confirm that the new DTD setup works as expected! As discussed a couple weeks ago, we will use just one event to send the different devtools event (same as the legacy devtools analytics). This one event will include a superset of all the parameters possible for all devtools related events (select, impressions, etc.). This is being added in package:unified_analytics in this PR.
The screenshot below shows the parameters that are being sent for the select event in the backend.
The highlighted field above for
eventCategorywill be how we filter for which devtools event we are interested in.