Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate select event to package:unified_analytics #7479

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Migrate select event to package:unified_analytics #7479

Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d41e02f
Initial commit
eliasyishak Mar 27, 2024
f1b31e7
Temp update for path to ua package
eliasyishak Mar 27, 2024
fca2142
Relabel the event params
eliasyishak Apr 2, 2024
55f0cf3
Update pubspec.yaml
eliasyishak Apr 2, 2024
ba4b73a
Update pubspec.yaml
eliasyishak Apr 2, 2024
915353a
Merge branch 'master' into migrate-select-event
eliasyishak Apr 18, 2024
4ca542b
Add dtd call to send select event
eliasyishak Apr 18, 2024
ae8079b
Clean up
eliasyishak Apr 18, 2024
6d6d763
Bump analytics to 6.1.0
eliasyishak Apr 22, 2024
a4c0c69
Merge remote-tracking branch 'upstream/master' into migrate-select-event
eliasyishak Apr 23, 2024
da61314
Merge remote-tracking branch 'upstream/master' into migrate-select-event
eliasyishak Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 44 additions & 9 deletions packages/devtools_app/lib/src/shared/analytics/_analytics_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import 'package:devtools_app_shared/ui.dart';
import 'package:flutter/foundation.dart';
import 'package:js/js.dart';
import 'package:logging/logging.dart';
import 'package:unified_analytics/unified_analytics.dart' as ua;
import 'package:web/web.dart';

import '../../../devtools.dart' as devtools show version;
Expand Down Expand Up @@ -642,18 +643,52 @@ void select(
'value:$value, '
'nonInteraction:$nonInteraction)',
);
final gtagEvent = _gtagEvent(
event_category: gac.selectEvent,
event_label: selectedItem,
value: value,
non_interaction: nonInteraction,
send_to: gaDevToolsPropertyId(),
screenMetrics:
screenMetricsProvider != null ? screenMetricsProvider() : null,
);
GTag.event(
screenName,
gaEventProvider: () => _gtagEvent(
event_category: gac.selectEvent,
event_label: selectedItem,
value: value,
non_interaction: nonInteraction,
send_to: gaDevToolsPropertyId(),
screenMetrics:
screenMetricsProvider != null ? screenMetricsProvider() : null,
),
gaEventProvider: () => gtagEvent,
);

final uaEvent = ua.Event.devtoolsEvent(
eventCategory: gtagEvent.event_category!,
label: gtagEvent.event_label!,
value: gtagEvent.value,
userInitiatedInteraction: !gtagEvent.non_interaction,
userApp: gtagEvent.user_app,
userBuild: gtagEvent.user_build,
userPlatform: gtagEvent.user_platform,
devtoolsPlatform: gtagEvent.devtools_platform,
devtoolsChrome: gtagEvent.devtools_chrome,
devtoolsVersion: gtagEvent.devtools_version,
ideLaunched: gtagEvent.ide_launched,
isExternalBuild: gtagEvent.is_external_build,
isEmbedded: gtagEvent.is_embedded,
ideLaunchedFeature: gtagEvent.ide_launched_feature,
g3Username: gtagEvent.g3_username,
uiDurationMicros: gtagEvent.ui_duration_micros,
rasterDurationMicros: gtagEvent.raster_duration_micros,
shaderCompilationDurationMicros:
gtagEvent.shader_compilation_duration_micros,
traceEventCount: gtagEvent.trace_event_count,
cpuSampleCount: gtagEvent.cpu_sample_count,
cpuStackDepth: gtagEvent.cpu_stack_depth,
heapDiffObjectsBefore: gtagEvent.heap_diff_objects_before,
heapDiffObjectsAfter: gtagEvent.heap_diff_objects_after,
heapObjectsTotal: gtagEvent.heap_objects_total,
rootSetCount: gtagEvent.root_set_count,
rowCount: gtagEvent.row_count,
inspectorTreeControllerId: gtagEvent.inspector_tree_controller_id,
Comment on lines +665 to +688
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we include all of the possible fields, most of these are nullable and if they are null when passed to Event.fromJson, those fields won't get sent to GA4

);

unawaited(dtdManager.sendAnalyticsEvent(uaEvent));
}

/// Sends an analytics event to signal that something in DevTools was viewed.
Expand Down
Loading