[google_maps_flutter] Drop iOS 11 support #5873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jenn Magder <magder@google.com>
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 15, 2024
flutter/packages@d74d687...d21f3b8 2024-01-14 engine-flutter-autoroll@skia.org Roll Flutter from 7dc856a to 1a2c315 (23 revisions) (flutter/packages#5895) 2024-01-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Add test that `onReceivedHttpAuthRequest` is cancelled by default (flutter/packages#5723) 2024-01-13 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 46787ee to ef1af02 (1 revision) (flutter/packages#5887) 2024-01-12 stuartmorgan@google.com [google_maps_flutter] Drop iOS 11 support (flutter/packages#5873) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter from 9f2e681 to 7dc856a (15 revisions) (flutter/packages#5882) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sybrands-place
pushed a commit
to sybrands-place/packages
that referenced
this pull request
Jan 16, 2024
* main: (186 commits) Roll Flutter from 7dc856a to 1a2c315 (23 revisions) (flutter#5895) [webview_flutter_android] Add test that `onReceivedHttpAuthRequest` is cancelled by default (flutter#5723) Roll Flutter (stable) from 46787ee49c1f to ef1af02aead6 (1 revision) (flutter#5887) [google_maps_flutter] Drop iOS 11 support (flutter#5873) Roll Flutter from 9f2e681 to 7dc856a (15 revisions) (flutter#5882) [ci] Check repo-level package metadata (flutter#5811) [various] Add iOS privacy manifests (flutter#5846) [video_player] Skip flaky tests in certain circumstances on Android (flutter#5872) Roll Flutter (stable) from 78666c8dc57e to 46787ee49c1f (5 revisions) (flutter#5870) Roll Flutter from b840a60 to 9f2e681 (24 revisions) (flutter#5871) [quick_actions_android] Close system dialogs for integration test (flutter#5853) [file_selector]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/file_selector/file_selector_android/android (flutter#5712) [in_app_pur]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter#5713) [url_launcher]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/url_launcher/url_launcher_android/android (flutter#5708) [image_picker]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter#5703) Roll Flutter from 126302d to b840a60 (29 revisions) (flutter#5855) Roll Flutter from c6ddb73 to 126302d (32 revisions) (flutter#5852) Bump github/codeql-action from 3.22.12 to 3.23.0 (flutter#5849) Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter#5841) [ci] Exclude quick_actions from Android emulators (flutter#5847) ... # Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFNavigationDelegateHostApi.m
stuartmorgan
added a commit
to stuartmorgan/packages
that referenced
this pull request
Jan 17, 2024
flutter#5873 removed a plugin-level workaround for a `podspec-lint` issue, under the incorrect belief that it was no longer necessary. Rather than re-add that, which degrades the experience for plugin clients who are targeting iOS 13+ with their apps, this adds a hack in the CI tooling itself to modify the podspec to require iOS 13 before linting. This could in theory cause false-positive lints about deprecated APIs, but currently doesn't, and that could be addressed in the unlikely event that it comes up. See flutter/flutter#94491
12 tasks
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Now that the latest Flutter stable requires iOS 12, and will auto-adjust projects, we can drop iOS 11 support in this plugin without breaking users. Having a minimum of iOS 12 means that Cocoapods should not resolve to anything older than Google Maps 6.x, which is the version that add arm64 simulator support, so the workaround to explicitly not build that can be removed. This means `google_maps_flutter` will no longer force projects into the buggier Rosetta iOS simulator path. This folds the iOS 11 and iOS 12 examples together, since (per `examples/README.md`) the iOS 11 version is the one containing most of the tests. To minimize the potential of losing tests due to mistakes, this was done by deleting the iOS *12* example, renaming the iOS 11 example, and then updating it to a minimum of 12. Fixes flutter/flutter#94491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the latest Flutter stable requires iOS 12, and will auto-adjust projects, we can drop iOS 11 support in this plugin without breaking users. Having a minimum of iOS 12 means that Cocoapods should not resolve to anything older than Google Maps 6.x, which is the version that add arm64 simulator support, so the workaround to explicitly not build that can be removed. This means
google_maps_flutterwill no longer force projects into the buggier Rosetta iOS simulator path.This folds the iOS 11 and iOS 12 examples together, since (per
examples/README.md) the iOS 11 version is the one containing most of the tests. To minimize the potential of losing tests due to mistakes, this was done by deleting the iOS 12 example, renaming the iOS 11 example, and then updating it to a minimum of 12.Fixes flutter/flutter#94491
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).