Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Work around Google Maps podspec lint issue #5913

Closed

Conversation

stuartmorgan
Copy link
Contributor

#5873 removed a plugin-level workaround for a podspec-lint issue, under the incorrect belief that it was no longer necessary. Rather than re-add that, which degrades the experience for plugin clients who are targeting iOS 13+ with their apps, this adds a hack in the CI tooling itself to modify the podspec to require iOS 13 before linting.

This could in theory cause false-positive lints about deprecated APIs, but currently doesn't, and that could be addressed in the unlikely event that it comes up.

See flutter/flutter#94491

flutter#5873 removed a plugin-level
workaround for a `podspec-lint` issue, under the incorrect belief that
it was no longer necessary. Rather than re-add that, which degrades the
experience for plugin clients who are targeting iOS 13+ with their apps,
this adds a hack in the CI tooling itself to modify the podspec to
require iOS 13 before linting.

This could in theory cause false-positive lints about deprecated APIs,
but currently doesn't, and that could be addressed in the unlikely event
that it comes up.

See flutter/flutter#94491
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan
Copy link
Contributor Author

test-exempt: is a test

(I did consider writing unit tests for this, but since the only purpose of this code is to make flutter/flutter#141493 work, I don't see any value to doing so: either it works and the CI we need is green, or it doesn't and the CI we need will be red.)

@stuartmorgan
Copy link
Contributor Author

Never mind; we have to put the plugin workaround back. I'll update the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant