[two_dimensional_scrollables] Fixes TreeViewNode collapsing not working #7474
Conversation
packages/two_dimensional_scrollables/test/tree_view/tree_test.dart
Outdated
Show resolved
Hide resolved
|
Can you also update the title of this PR to reflect this package? It currently refers to the framework change, not this one. Also, the PR template for this repo is different from the framework. For example, it specifies the title of the PR should start with the [name_of_package]. |
Piinks
added
the
p: two_dimensional_scrollables
Piinks
changed the title
Piinks
changed the title
Mairramer
changed the title
| @@ -718,6 +718,101 @@ void main() { | |||
| expect(treeView.treeNodeBuilder, isA<TreeViewNodeBuilder<String>>()); | |||
| expect(treeView.treeRowBuilder, isA<TreeViewRowBuilder<String>>()); | |||
| }); | |||
|
|
|||
| testWidgets( | |||
There was a problem hiding this comment.
Similar to the framework change, this test does not fail when run without the code change. It should so it verifies the fix works as expected, and prevents us from regressing in the future.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
@Piinks Same of comment flutter/flutter#153438 (comment). |
This change addresses bug #154295 by ensuring that nodes are handled correctly when closing their children.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.