Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[two_dimensional_scrollables] Fixes TreeViewNode collapsing not working #7474

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+11 −5
Open

[two_dimensional_scrollables] Fixes TreeViewNode collapsing not working #7474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
12de8ce
fix unpack to work correctly.
Mairramer Aug 21, 2024
96aabf8
fix identation
Mairramer Aug 21, 2024
dac4bac
fix format
Mairramer Aug 22, 2024
5afe75d
fix
Mairramer Aug 22, 2024
936c1cb
fix format
Mairramer Aug 22, 2024
24df710
fix
Mairramer Aug 22, 2024
03e24ab
fix
Mairramer Sep 23, 2024
433ccd3
Merge branch 'main' into fix/treesliver-collapsing-not-working
Mairramer Sep 23, 2024
6644a03
fix
Mairramer Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/two_dimensional_scrollables/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## NEXT
## 0.3.3

* Fixes an issue where collapsing nodes in the TreeView didn't work correctly.

## 0.3.2

Expand Down
10 changes: 7 additions & 3 deletions packages/two_dimensional_scrollables/lib/src/tree_view/tree.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,6 +911,12 @@ class _TreeViewState<T> extends State<TreeView<T>>
_currentAnimationForParent[node]!.controller.dispose();
_currentAnimationForParent.remove(node);
_updateActiveAnimations();
// If the node is collapsing, we need to unpack the active
// nodes to remove the ones that were removed from the tree.
// This is only necessary if the node is collapsing.
if (!node._expanded) {
_unpackActiveNodes();
}
case AnimationStatus.forward:
case AnimationStatus.reverse:
}
Expand Down Expand Up @@ -949,9 +955,7 @@ class _TreeViewState<T> extends State<TreeView<T>>
controller.forward();
case false:
// Collapsing
controller.reverse().then((_) {
_unpackActiveNodes();
});
controller.reverse();
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/two_dimensional_scrollables/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: two_dimensional_scrollables
description: Widgets that scroll using the two dimensional scrolling foundation.
version: 0.3.2
version: 0.3.3
repository: https://github.com/flutter/packages/tree/main/packages/two_dimensional_scrollables
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+two_dimensional_scrollables%22+

Expand Down