[bitnami/gitea] Use different liveness/readiness probes (bitnami#25987)

Signed-off-by: David Gomez <dgomezleon@vmware.com> Signed-off-by: Fran Mulero <fmulero@vmware.com>
fmulero · May 22, 2024 · 5f89571 · 5f89571
1 parent fe5a9ea
commit 5f89571
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 14 deletions.
diff --git a/bitnami/gitea/Chart.lock b/bitnami/gitea/Chart.lock
@@ -1,9 +1,9 @@
 dependencies:
 - name: postgresql
   repository: oci://registry-1.docker.io/bitnamicharts
-  version: 15.3.2
+  version: 15.3.3
 - name: common
   repository: oci://registry-1.docker.io/bitnamicharts
   version: 2.19.2
-digest: sha256:b3be00d62395c3cbec87e3ed0b505d68b48a969323d3e4bb14428dca34c75a52
-generated: "2024-05-18T01:03:17.144495516Z"
+digest: sha256:95905b036bd584a4bd45bd69e8b5f1b837adbcd1eb75318e0cc2674d58936c1a
+generated: "2024-05-20T10:46:41.675004+02:00"
diff --git a/bitnami/gitea/Chart.yaml b/bitnami/gitea/Chart.yaml
@@ -37,4 +37,4 @@ maintainers:
 name: gitea
 sources:
 - https://github.com/bitnami/charts/tree/main/bitnami/gitea
-version: 2.1.1
+version: 2.1.2
diff --git a/bitnami/gitea/README.md b/bitnami/gitea/README.md
@@ -230,7 +230,6 @@ helm install my-release --set persistence.existingClaim=PVC_NAME oci://REGISTRY_
 | `startupProbe.failureThreshold`                     | Failure threshold for startupProbe                                                                                                                                                                                | `5`                     |
 | `startupProbe.successThreshold`                     | Success threshold for startupProbe                                                                                                                                                                                | `1`                     |
 | `livenessProbe.enabled`                             | Enable livenessProbe                                                                                                                                                                                              | `true`                  |
-| `livenessProbe.path`                                | Request path for livenessProbe                                                                                                                                                                                    | `/`                     |
 | `livenessProbe.initialDelaySeconds`                 | Initial delay seconds for livenessProbe                                                                                                                                                                           | `600`                   |
 | `livenessProbe.periodSeconds`                       | Period seconds for livenessProbe                                                                                                                                                                                  | `10`                    |
 | `livenessProbe.timeoutSeconds`                      | Timeout seconds for livenessProbe                                                                                                                                                                                 | `5`                     |

diff --git a/bitnami/gitea/templates/deployment.yaml b/bitnami/gitea/templates/deployment.yaml
@@ -228,8 +228,7 @@ spec:
           livenessProbe: {{- include "common.tplvalues.render" (dict "value" .Values.customLivenessProbe "context" $) | nindent 12 }}
           {{- else if .Values.livenessProbe.enabled }}
           livenessProbe:
-            httpGet:
-              path: {{ .Values.livenessProbe.path }}
+            tcpSocket:
               port: http
             initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
             periodSeconds: {{ .Values.livenessProbe.periodSeconds }}

diff --git a/bitnami/gitea/values.yaml b/bitnami/gitea/values.yaml
@@ -377,13 +377,8 @@ startupProbe:
   failureThreshold: 5
   successThreshold: 1
 ## Configure extra options for liveness probe
-## Gitea core exposes / to unauthenticated requests, making it a good
-## default liveness and readiness path. However, that may not always be the
-## case. For example, if the image value is overridden to an image containing a
-## module that alters that route, or an image that does not auto-install Gitea.
 ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes
 ## @param livenessProbe.enabled Enable livenessProbe
-## @param livenessProbe.path Request path for livenessProbe
 ## @param livenessProbe.initialDelaySeconds Initial delay seconds for livenessProbe
 ## @param livenessProbe.periodSeconds Period seconds for livenessProbe
 ## @param livenessProbe.timeoutSeconds Timeout seconds for livenessProbe
@@ -392,15 +387,14 @@ startupProbe:
 ##
 livenessProbe:
   enabled: true
-  path: /
   initialDelaySeconds: 600
   periodSeconds: 10
   timeoutSeconds: 5
   failureThreshold: 5
   successThreshold: 1
 ## Configure extra options for readiness probe
 ## Gitea core exposes / to unauthenticated requests, making it a good
-## default liveness and readiness path. However, that may not always be the
+## default startup and readiness path. However, that may not always be the
 ## case. For example, if the image value is overridden to an image containing a
 ## module that alters that route, or an image that does not auto-install Gitea.
 ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes