Skip to content

Commit

Permalink
[bitnami/opencart] Use different liveness/readiness probes (bitnami#2…
Browse files Browse the repository at this point in the history
…5973)

Signed-off-by: David Gomez <dgomezleon@vmware.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
  • Loading branch information
dgomezleon authored and fmulero committed May 22, 2024
1 parent 1b503dd commit fe5a9ea
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 12 deletions.
6 changes: 3 additions & 3 deletions bitnami/opencart/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
dependencies:
- name: mariadb
repository: oci://registry-1.docker.io/bitnamicharts
version: 18.0.5
version: 18.0.6
- name: common
repository: oci://registry-1.docker.io/bitnamicharts
version: 2.19.2
digest: sha256:c5470e186b8c675df045d2df334629fb8a47a53f87044bd4348c80105ca25eaf
generated: "2024-05-18T02:18:04.4388818Z"
digest: sha256:c47e6893bd32647cb5b1ace19e702087fa6e5301cd7e7b37eae4313afa327e2c
generated: "2024-05-20T09:19:25.860727+02:00"
2 changes: 1 addition & 1 deletion bitnami/opencart/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ maintainers:
name: opencart
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/opencart
version: 18.0.4
version: 18.0.5
1 change: 0 additions & 1 deletion bitnami/opencart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ helm install my-release --set persistence.existingClaim=PVC_NAME oci://REGISTRY_
| `startupProbe.failureThreshold` | Failure threshold for startupProbe | `6` |
| `startupProbe.successThreshold` | Success threshold for startupProbe | `1` |
| `livenessProbe.enabled` | Enable livenessProbe | `true` |
| `livenessProbe.path` | Request path for livenessProbe | `/administration/` |
| `livenessProbe.initialDelaySeconds` | Initial delay seconds for livenessProbe | `120` |
| `livenessProbe.periodSeconds` | Period seconds for livenessProbe | `10` |
| `livenessProbe.timeoutSeconds` | Timeout seconds for livenessProbe | `5` |
Expand Down
6 changes: 1 addition & 5 deletions bitnami/opencart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -295,12 +295,8 @@ spec:
livenessProbe: {{- include "common.tplvalues.render" (dict "value" .Values.customLivenessProbe "context" $) | nindent 12 }}
{{- else if .Values.livenessProbe.enabled }}
livenessProbe:
httpGet:
path: {{ .Values.livenessProbe.path }}
tcpSocket:
port: http
httpHeaders:
- name: Host
value: {{ include "opencart.host" . | quote }}
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.livenessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }}
Expand Down
2 changes: 0 additions & 2 deletions bitnami/opencart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,6 @@ startupProbe:
## Configure extra options for liveness probe
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes
## @param livenessProbe.enabled Enable livenessProbe
## @param livenessProbe.path Request path for livenessProbe
## @param livenessProbe.initialDelaySeconds Initial delay seconds for livenessProbe
## @param livenessProbe.periodSeconds Period seconds for livenessProbe
## @param livenessProbe.timeoutSeconds Timeout seconds for livenessProbe
Expand All @@ -373,7 +372,6 @@ startupProbe:
##
livenessProbe:
enabled: true
path: /administration/
initialDelaySeconds: 120
periodSeconds: 10
timeoutSeconds: 5
Expand Down

0 comments on commit fe5a9ea

Please sign in to comment.