tinygo support, goroutine hack change, fix panic for invalid stderr, add test #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldemailly
changed the title
ldemailly
changed the title
ccoVeille
reviewed
Jul 17, 2024
ccoVeille
reviewed
Jul 17, 2024
ccoVeille
reviewed
Jul 17, 2024
ldemailly
commented
Jul 17, 2024
ldemailly
commented
Jul 17, 2024
indicate why we don't just use io.Discard, some more cc @ccoVeille
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
===========================================
- Coverage 100.00% 99.02% -0.98%
===========================================
Files 4 6 +2
Lines 550 618 +68
===========================================
+ Hits 550 612 +62
- Misses 0 4 +4
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
ccoVeille
reviewed
Jul 18, 2024
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
ccoVeille
approved these changes
Jul 18, 2024
|
So I got it to link even though I have yet to get it to run with tinygo See but once these merge/are resolved, this will be tinygo compatible ps: because tinygo doesn't have stack traces the file name/line number tests do fail but it's ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
For tinygo (once debug.Buildinfo is fixed in tinygo-org/tinygo#4343) the issue was the linkname hacks that work for go do not exist, but there is instead a
internal/task.Currentthat we use but convert to an id because... folks aren't convinced we need an id (even though we do...)Also switched to letting https://github.com/kortschak/goroutine deal with maintaining the hack (adds a dependency but... oh well)