Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinygo support, goroutine hack change, fix panic for invalid stderr, add test #66

Merged
merged 12 commits into from
Jul 19, 2024
Merged

tinygo support, goroutine hack change, fix panic for invalid stderr, add test #66

merged 12 commits into from
Jul 19, 2024

Commits on Jul 16, 2024

  1. Fix panic for invalid stderr, add test

    @ldemailly
    ldemailly committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a8776ba View commit details
    Browse the repository at this point in the history

  2. auto switch to stdout for wasm - manual tested

    @ldemailly
    ldemailly committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f9c8a21 View commit details
    Browse the repository at this point in the history

  3. Throw the towel on goroutine, use the original directly, maintained f… 

    …or changes in linkname
    @ldemailly
    ldemailly committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    eeef157 View commit details
    Browse the repository at this point in the history

  4. add alternative used to benchmark

    @ldemailly
    ldemailly committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a9bec02 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. happy linters, happy life

    @ldemailly
    ldemailly committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ddcb430 View commit details
    Browse the repository at this point in the history

  2. Add comment about the mutex

    @ldemailly
    ldemailly committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8c81506 View commit details
    Browse the repository at this point in the history

  3. review comments, thanks @ccoVeille for the thorough look

    @ldemailly
    ldemailly committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    376fcdf View commit details
    Browse the repository at this point in the history

  4. Update logger_test.go

    @ldemailly
    ldemailly committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2097233 View commit details
    Browse the repository at this point in the history

  5. Update logger_test.go 

    indicate why we don't just use io.Discard, some more

cc @ccoVeille
    @ldemailly
    ldemailly committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    086f2e4 View commit details
    Browse the repository at this point in the history

  6. increase coverage where possible, ie not in init()

    @ldemailly
    ldemailly committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    531e709 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Apply suggestions from code review 

    Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
    @ldemailly @ccoVeille
    ldemailly and ccoVeille committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    867aa5c View commit details
    Browse the repository at this point in the history

  2. more explanations of

    @ldemailly
    ldemailly committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    44cf645 View commit details
    Browse the repository at this point in the history