-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve installation, setup and usage documentation of different Grids #10843
Comments
Adding to this, the XY grid docs should be more consistent with the order of classes. Some of the examples end with the <div class="grid-x">
<div class="small-6 cell">6 cells</div>
<div class="small-6 cell">6 cells</div>
</div> While other examples start with the cell class: <div class="grid-container">
<div class="grid-x grid-margin-x">
<div class="cell small-4">cell</div>
<div class="cell small-4">cell</div>
<div class="cell small-4">cell</div>
</div>
</div> I think the |
@colin-marshall Personally, I prefer when
<div class="baseone basetwo verry-long-modifier"></div>
<div class="baseone basetwo small-modifier"></div>
<div class="baseone basetwo another-modifier"></div> <div class="verry-long-modifier baseone basetwo"></div>
<div class="small-modifier baseone basetwo"></div>
<div class="another-modifier baseone basetwo"></div> But I agree with you, it needs to be consistent across all examples. We also need to be consistent with the whole CSS community (who usually put "base" before "modifier") 😜 . |
@ncoden you persuaded me. I agree, |
Merged #10866 |
Some people around me recently reported they did not understand well how Float / Flex / XY Grids can be installed or imported, setup and used. Particullary what grid is included by default and how to get others grids.
The text was updated successfully, but these errors were encountered: