Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation, setup and usage documentation of different Grids #10843

Closed
ncoden opened this issue Jan 9, 2018 · 4 comments
Closed

Improve installation, setup and usage documentation of different Grids #10843

ncoden opened this issue Jan 9, 2018 · 4 comments
Assignees

Comments

@ncoden
Copy link
Contributor

ncoden commented Jan 9, 2018

Some people around me recently reported they did not understand well how Float / Flex / XY Grids can be installed or imported, setup and used. Particullary what grid is included by default and how to get others grids.

@ncoden ncoden self-assigned this Jan 9, 2018
@colin-marshall
Copy link
Contributor

Adding to this, the XY grid docs should be more consistent with the order of classes. Some of the examples end with the cell class, like this:

<div class="grid-x">
  <div class="small-6 cell">6 cells</div>
  <div class="small-6 cell">6 cells</div>
</div>

While other examples start with the cell class:

<div class="grid-container">
  <div class="grid-x grid-margin-x">
    <div class="cell small-4">cell</div>
    <div class="cell small-4">cell</div>
    <div class="cell small-4">cell</div>
  </div>
</div>

I think the cell class should always be at the end, to keep in line with how the columns class always appeared at the end in the float grid. If somebody has a good argument for it being at the beginning, I'm open to that, but it needs to be consistent across all examples.

@ncoden
Copy link
Contributor Author

ncoden commented Jan 16, 2018

@colin-marshall Personally, I prefer when small-4 is after cell for the following reasons:

  • cell is the base, small-4 modify it. The action of small-4 happens after.
  • cell properties must be defined before small-4 properties.
  • Almost always in a list of components, the base will be the same while the modifiers change. It is easier to read a list and compare changes when changes happend latter on the line.
<div class="baseone basetwo verry-long-modifier"></div>
<div class="baseone basetwo small-modifier"></div>
<div class="baseone basetwo another-modifier"></div>
<div class="verry-long-modifier baseone basetwo"></div>
<div class="small-modifier baseone basetwo"></div>
<div class="another-modifier baseone basetwo"></div>

But I agree with you, it needs to be consistent across all examples. We also need to be consistent with the whole CSS community (who usually put "base" before "modifier") 😜 .

@colin-marshall
Copy link
Contributor

@ncoden you persuaded me. I agree, cell should definitely come first.

ncoden added a commit to ncoden/foundation-sites that referenced this issue Jan 18, 2018
@ncoden ncoden closed this as completed Jan 20, 2018
@ncoden
Copy link
Contributor Author

ncoden commented Jan 20, 2018

Merged #10866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants