Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Release v6.5.0-rc.1 #11340

Merged
merged 197 commits into from
Jun 24, 2018
Merged

🚀 Release v6.5.0-rc.1 #11340

merged 197 commits into from
Jun 24, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Jun 16, 2018 •
edited
Loading

Foundation v6.5.0 Release Candidate 1

Here we go! Foundation 6.5 is out now and comes with a lot of bug fixes and various improvements! This release is mainly focused on stabilizing the previous release, improving accessibility and browser support and making the integration with your project easier. New features were delayed to the next release to ensure the best compatibility with v6.4.4-rc1. Check out the details below.

Note about this pull request

As this version was built to have the best compatibility with v6.4.4-rc1, we used a dedicated branch and manually picked safe changes from the development branch develop, excluding API evolutions and breaking changes. These imported changes are the Use pull request #xxx commits you can see in this pull request. Development will continue on develop and will lead to a future release with all changes, including new features and breaking changes.

Release Checklist

  • Bump versions
  • Update Lockfiles
  • Update dist files
  • Update SCSS settings file
    ▾
  • Update documentation
    ▾
  • Prepare release for npm
    • Updated package.json version
    • Updated .npmignore
  • Prepare release for Rails
  • Prepare release for Meteor Do not support pre-releases
    • Updated package.js version and source file list
    • ⚠️  Must be published before the Git release for .versions
  • Prepare release for Composer
    • Updated composer.json version
  • Prepare release for NuGet
  • Released!

Highlighs


All changes

This release comes with ~230 contributions like new features, improvements, bug fixes, documentation updates and maintenance tasks. This changelog uses the following emojis to describe contribution types.

Code changes Cleaning Maintenance
💥 Breaking changes
🚀 Features
✨ Improvements
🐛 Bug Fixes		 🛠️ Refactoring
💎 Linting
📖 Documentation

 💻 Tools
📦 Dependencies
🚚 Build files
🚨 Tests

Changes marked with RC were included in the previous unstable release candidate v6.4.4-rc1. They may have introduced new features and visual changes. If you have already migrated to Foundation v6.4.4-rc1 without encountering issues, you can safely migrate to v6.5.0.

General

Controls

Navigation

Containers

Media

Plugins

Utilities

Global / Miscellaneous


Contributors

Big thanks to our 75 amazing contributors who helped to make Foundation even better. Foundation wouldn't happen without you! Also thanks to our 87 others contributors who worked on new features, your contributions will be released in the next version.

[227] - Nicolas Coden (@ncoden)
 [95] - Daniel Ruf (@DanielRuf)
 [20] - Kevin Ball (@kball)
 [27] - Harry Manchanda (@IamManchanda)
 [18] - RafiBomb (@rafibomb)
 [12] - Marius Olbertz (@Owlbertz)
  [5] - SassNinja (@SassNinja)
  [4] - Colin Marshall (@colin-marshall)
  [4] - David Niciforovic
  [3] - Aaron Arney (@ocularrhythm)
  [3] - colinmackinlay (@colinmackinlay)
  [3] - danclayton50 (@danclayton50)
  [3] - JasonMiller (@JasonMiller)
  [3] - Joakim Nystrom (@jnystromdesign)
  [2] - alliclemens (@alliclemens)
  [2] - Ben Holden-Crowther (@benhc123)
  [2] - Daniel Rhodes (@danielrhodeswarp)
  [2] - David Newman
  [2] - Grant Carthew (@grantcarthew)
  [2] - Kamil Breguła (@mik-laj)
  [2] - Kerry (@flatline-studios)
  [2] - Martin Hofmann (@Martskin)
  [2] - Nicolas Venegas (@nicolasv)
  [2] - Raymond Young (@raym)
  [2] - Stefan Lisper
  [1] - Abdullah Salem (@abdullahsalem)
  [1] - Adam Klepacz (@adamklepacz)
  [1] - Anagh Sharma (@AnaghSharma)
  [1] - Andrew France (@Odaeus)
  [1] - Andy Cochran (@andycochran)
  [1] - Anton Kudryavtsev (@Anidetrix)
  [1] - Arjen Kroeze (@arjenkroeze)
  [1] - ArtbyPravesh (@artbypravesh)
  [1] - Bhupinder Singh (@u671175)
  [1] - Bram de Leeuw (@TheBnl)
  [1] - Brett Mason (@brettsmason)
  [1] - Brian Shanley (@brianshano)
  [1] - Chris (@paxperscientiam)
  [1] - Corey Snyder (@coreysyms)
  [1] - Dinis Correia (@diniscorreia)
  [1] - Gaël Poupard (@ffoodd)
  [1] - Guillaume Paumier (@gpaumier)
  [1] - Ian Caunce (@IanCaunce)
  [1] - Jeremy Englert
  [1] - Jesse Doyle (@jessedoyle)
  [1] - JuanMME (@JuanMME)
  [1] - koki-higashikawa
  [1] - Kristofer Krause (@dragthor)
  [1] - Lukas Drgon (@LukasDrgon)
  [1] - Luke Arentz (@svenkle)
  [1] - Mahdi Ziraki (@mziraki)
  [1] - Mehdi Kabab (@piouPiouM)
  [1] - Nic Winn (@nicwinn)
  [1] - Olena Pastushenko (@lirael)
  [1] - Osman Gormus (@gormus)
  [1] - Pete Deffendol (@pdeffendol)
  [1] - Petr Tomášek (@GITTomy)
  [1] - powellian (@powellian)
  [1] - r.bos
  [1] - Richard Taylor (@farrago)
  [1] - Rick Hawkins (@rlhawk)
  [1] - Robert Gaul (@gaulrobe)
  [1] - Robert Martin (@rbrtmrtn)
  [1] - Roy (@RvWensen)
  [1] - Shaun Simmons (@simshaun)
  [1] - skadzielawa (@skadzielawa)
  [1] - TakteS (@TakteS)
  [1] - therufa (@therufa)
  [1] - Tom (@knabe)
  [1] - Tom English (@englishtom)
  [1] - TonyMtz (@tonymtz)
  [1] - wesdawg
  [1] - wolfbeisz (@wolfbeisz)
  [1] - Yuchen Xie (@mapx)
  [1] - ZURBywood

pdeffendol and others added 30 commits June 16, 2018 08:59
@pdeffendol @ncoden
Use pull request foundation#10698 from pdeffendol/patch-1 for v6.5.0
56787e7 
fd33d80 Fix autoprefixer documentation for Sass setup

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@skadzielawa @ncoden
Use pull request foundation#10710 from skadzielawa/patch-1 for v6.5.0
fd75873 
f0f8821 Update starter-projects.md

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@artbypravesh @ncoden
Use pull request foundation#10719 from artbypravesh/master for v6.5.0
881c57a 
a2fc4f5 Fix typo in javascript docs page

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10815 from kirra/develop for v6.5.0
8b1a93c 
c36cdf4 Changed `$foundation-palette` to `$button-palette`

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10807 from Anidetrix/patch-1 for v6.5.0
c76d513 
8cac92f Fix Keyboard util TypeScript declaration

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@rlhawk @ncoden
Use pull request foundation#10778 from rlhawk/patch-1 for v6.5.0
1a3b122 
33a5884 Update xy-grid.md

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10785 from IanCaunce/fix.functionDocs for…
b2a2393 
… v6.5.0

7580322 Fixed typo in the rem-calc's documentation

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@IamManchanda @ncoden
Use pull request foundation#10752 from zurb/thumnails-standarize for …
c28c05a 
…v6.5.0

b3fd9ea Just to keep things standard

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@DanielRuf @ncoden
Use pull request foundation#10731 from DanielRuf/patch-accordion-smud…
a435dff 
…ge-delay-master for v6.5.0

5aa4b92 fix data attribute name

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@DanielRuf @ncoden
Use pull request foundation#10729 from DanielRuf/patch-on-load for v6…
131fa96 
….5.0

4ad4a07 use on() to listen for the load event
de54ab2 use on() to listen for the load event

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@LukasDrgon @ncoden
Use pull request foundation#10720 from LukasDrgon/patch-3 for v6.5.0
7317af8 
b3252ac Add jsDelivr hits badge

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@mziraki @ncoden
Use pull request foundation#10709 from mziraki/patch-1 for v6.5.0
00d2352 
32c804a fix typo in doc

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10703 from zurb/fix10693 for v6.5.0
d142bd1 
82afc2d adds more details to buttongroup variable
e5d89c2 fixes foundation#10693 stack button group always expanded
566989c adds use case for medium down and adds a visual test

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10822 from ncoden/docs/update-sri for v6.5.0
187a497 
492fb15 docs: update sub-ressources integrity

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@Owlbertz @IamManchanda @ncoden
Use pull request foundation#10711 from Owlbertz/reveal-anchor-focus-f…
36a634f 
…ix for v6.5.0

9fce99e Focus active anchor rather than last one in collection when closing a Reveal modal.
9e8535a Added tests for foundation#10604.
f954f7e Added visual test for foundation#10604.
6cfebc3 Update Yarn file!
6bc8691 Revert "Update Yarn file!"

Co-Authored-By: Harry Manchanda <harmanmanchanda182@gmail.com>
Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@Martskin @ncoden
Use pull request foundation#10679 from Martskin/fix-media-object-mixi…
518b233 
…n-flex-mode for v6.5.0

310e3dc Addresses Media Object mixin issue in Flex mode. foundation#9038.
af9d697 Adds Media Object visual test page.
606f164 fix: prevent side-effect from .stack-for in media-object

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10823 from ncoden/chore/update-babel for …
65c05e9 
…v6.5.0

a180ffa chore: update babel packages
3d130a5 chore: update lock files

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10825 from raym/develop for v6.5.0
425810a 
244a684 update version of `fourseven:scss` dependency
821e478 remove comma after last element in array. was throwing syntax error

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10827 from ncoden/fix/remove-tab-outline-…
469a24a 
…on-mouse-10798 for v6.5.0

856cf61 fix: remove tab outline on mouse foundation#10798

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10830 from ncoden/docs/button-disabled-pa…
3bf69ef 
…rams-typo-10783 for v6.5.0

54cf839 docs: fix typo for `button-disabled` param types foundation#10783

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@benhc123 @ncoden
Use pull request foundation#10831 from benhc123/patch-2 for v6.5.0
739d410 
9b7e2ac Updated to 2018
0c484bc docs: update to 2018

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@Owlbertz @ncoden
Use pull request foundation#10829 from Owlbertz/drilldown-parent-fix …
c14720b 
…for v6.5.0

e30db54 Fix Drilldown behavior with parent link when using keyboard.
2c4b3f9 Added test for fix for  foundation#10803.

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use commit 5c679d2 for v6.5.0
e73d726 
5c679d2 swaps footer form to button and updates footer copywrite

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@gpaumier @ncoden
Use pull request foundation#10835 from gpaumier/patch-1 for v6.5.0
18ab3d6 
c52a9f8 typo
40d3b04 docs: fix typo in "upcoming"

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@nvenegas @ncoden
Use pull request foundation#10837 from nicolasv/bugfix/10836-magellan…
73ea600 
…-clear-hash for v6.5.0

9b8129a chore: Fix != comparison in Magellan.
6fb7092 Clear hash in Magellan deep linking when there is no active link.
ba938ce fix: prevent to loose query params when reseting hash in magellan

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10834 from ncoden/docs/remove-undefined-x…
d92e45d 
…y-cell-breakpoints-10276 for v6.5.0

4b3be7d docs: remove undefined mixin `xy-cell-breakpoints` foundation#10276

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@benhc123 @ncoden
Use pull request foundation#10839 from benhc123/patch-4 for v6.5.0
675879e 
c8d0cc3 Inc. vs inc.
9451582 type: change inc. to Inc. in LICENSE

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10821 from ncoden/fix/xy-cell-with-invali…
d9f3280 
…d-breakpoint for v6.5.0

e0f8eae fix: do not generate invalid xy-cell when breakpoint is not found

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10819 from ncoden/fix/fix-bp-size-leak-#1…
f1a09cc 
…0818 for v6.5.0

31f46c2 fix: prevent leaking of `-zf-size` in `-zf-each-breakpoint` mixin

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Use pull request foundation#10840 from ncoden/fix/dropdown-anchor-att…
e7b4208 
…ributes-10627 for v6.5.0

8bad6ed fix: fix dropdown aria-labelledby from its anchor id
401618a fix: fix dropdown default alignement based on float class

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@Owlbertz
Copy link
Contributor

@ncoden FYI: seems like you got something wrong with the mentions in the list of contributors.

@ncoden
Copy link
Contributor Author

ncoden commented Jun 18, 2018

@Owlbertz Oh, true ^^

@SassNinja
Copy link
Contributor

@ncoden there seems to be a mistake in the contributors list.

I often wish I could clone myself but not possible yet 😉
Should be just Kai Falkowski (SassNinja)

bildschirmfoto 2018-06-19 um 08 45 08

@SassNinja
Copy link
Contributor

I tried to test the release branch by executing npm start but it fails after having started the task docs:all. I got the following error message:

(node:29386) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): JSDOC_ERROR: There are no input files to process.
(node:29386) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:29386) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 3): JSDOC_ERROR: There are no input files to process.

The error source seems to be the supercollider (maybe in its lib/parse.js)
Did anyone else face this problem?

I'm using node v8.9.4 (Mac OS)

@ncoden
Copy link
Contributor Author

ncoden commented Jun 19, 2018

@SassNinja Did you rm -rf node_modules && npm i ?

@SassNinja
Copy link
Contributor

@ncoden I did clone your fork so clean node modules

However I've also tried with rm -rf but same result: error in docs:all task.
I'll try again on another computer later.

@DanielRuf
Copy link
Contributor

The needed files (css, js) probably do not yet exist.

@tsquez
Copy link
Contributor

tsquez commented Jun 19, 2018

Is there a way to download this to test locally. I don't run builds or compile, I just download and use it with WordPress.

@ncoden
Copy link
Contributor Author

ncoden commented Jun 19, 2018 •
edited
Loading

@tsquez It's not released yet so no. This pull request is intended for Foundation developers only. You will be able to test 6.5.0-rc.1 once released.

@DanielRuf DanielRuf mentioned this pull request Jun 19, 2018
Closed
@rafibomb
Copy link
Member

Team, really well put together release notes!

abdullahsalem
abdullahsalem approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@abdullahsalem abdullahsalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just quickly reviewed this PR, and it looks fine to me.
Many thanks guys for this great work!

@ncoden
Use pull request foundation#11341 from ncoden/fix/reveal-single-scrol…
99a6eba 
…lbar-7831 for v6.5.0

96141b7 docs: add doc for Reveal methods _addGlobalClasses/_removeGlobalClasses
deda9dc refactor: rename Reveal internal methods for a better clarity
82a0493 fix: show/hide Reveal scrollbar on window resizing
e6eb9b0 fix: keep a scrollbar on document when Reveal opens foundation#7831

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
chore: bump version for v6.5.0-rc.1
8fe324d
@ncoden
chore: update lockfiles for v6.5.0-rc.1
496fcf1
@ncoden
chore: generate dist files for v6.5.0-rc.1
7259dff
@ncoden
chore: generate SCSS settings for v6.5.0-rc.1
4844ebc
@ncoden
docs: update documentation for v6.5.0-rc.1
cf617c9
@ncoden
chore: update .gitignore & .npmignore files
88b35a7
@ncoden
chore: add keywords to package.json
814a17d
DanielRuf
DanielRuf reviewed Jun 21, 2018
View reviewed changes
.npmignore
testing/_build
test/javascript/js-tests.js

pizza/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More pizza for us

@ncoden ncoden mentioned this pull request Jun 21, 2018
Closed
@ncoden
chore: update Package.js source files
80f127c 
Update the list of source files in package.js for meteor
@ncoden
Use pull request foundation#11349 from ncoden/fix/meteor-fourseven-sc…
f22c67c 
…ss-compatibility for v6.5.0

009b469 fix: revise Meteor "fourseven:scss" compatibility for better Meteor support

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden merged commit 397084a into foundation:support/6.5 Jun 24, 2018
@ncoden ncoden mentioned this pull request Jul 1, 2018
Merged
14 tasks
@ncoden ncoden added 🚀 Release and removed WIP labels Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

@abdullahsalem abdullahsalem abdullahsalem approved these changes

@DaSchTour DaSchTour DaSchTour approved these changes

@rafibomb rafibomb rafibomb approved these changes

@kball kball Awaiting requested review from kball

@brettsmason brettsmason Awaiting requested review from brettsmason

@andycochran andycochran Awaiting requested review from andycochran

@coreysyms coreysyms Awaiting requested review from coreysyms

@colin-marshall colin-marshall Awaiting requested review from colin-marshall

@JeremyEnglert JeremyEnglert Awaiting requested review from JeremyEnglert

@paxperscientiam paxperscientiam Awaiting requested review from paxperscientiam

@IAmEddieDean IAmEddieDean Awaiting requested review from IAmEddieDean

@SassNinja SassNinja Awaiting requested review from SassNinja

Assignees
No one assigned
Labels
🚀 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.