Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: fix side-effect of jQuery .filter() in Abide.addA11yAttr… #10936

Merged
merged 1 commit into from Feb 17, 2018
Merged

Revert "fix: fix side-effect of jQuery .filter() in Abide.addA11yAttr… #10936

merged 1 commit into from Feb 17, 2018

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Feb 13, 2018 •
edited
Loading

…ibutes", fixes #10935

This reverts commit c6a6906.

@ncoden
Copy link
Contributor

ncoden commented Feb 13, 2018

Did you check if units and visual tests runs well ?

@DanielRuf
Copy link
Contributor Author

.end() makes not much sense here and is not used in the other js component test files. The unit tests and browser tests run without any issues.

.end() is for popping the jQuery selector stack.

@DanielRuf
Copy link
Contributor Author

Also fixes the two currently failing unit tests in #10938

@ncoden ncoden mentioned this pull request Feb 15, 2018
Closed
3 tasks
ncoden
ncoden approved these changes Feb 17, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ncoden ncoden merged commit e23b2ef into foundation:develop Feb 17, 2018
@DanielRuf DanielRuf deleted the patch/abide-stack-revert-end branch February 17, 2018 23:10
@ncoden ncoden mentioned this pull request Feb 18, 2018
Closed
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@DanielRuf @ncoden
Use pull request foundation#10936 from DanielRuf/patch/abide-stack-re…
803d04e 
…vert-end for v6.5.0

1840a11 Revert "fix: fix side-effect of jQuery .filter() in Abide.addA11yAttributes", fixes foundation#10935

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
Abide bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing Unit Tests - develop Branch
2 participants
@DanielRuf @ncoden