Code refactor for spacing classes! #10625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kball
reviewed
Sep 7, 2017
scss/prototype/_spacing.scss
Outdated
| @each $prop in (margin, padding) { | ||
| // All Sides | ||
| .#{$prop}-#{$spacer} { | ||
| @if ($prop == margin) { @include margin($spacer, $spacer, $spacer, $spacer); } |
There was a problem hiding this comment.
I like the loops, but lets have the @include on its own line, so more like
@if ($prop == margin) {
@include margin($spacer, $spacer, $spacer, $spacer);
} @else if ($prop == padding) {
@include padding($spacer, $spacer, $spacer, $spacer);
}
|
done @kball Indentation and also some more cool refactor Also, This removes the dirt of |
Keeping migration for another PR and 6.5
|
@kball As discussed, I have removed the map for now, as we would have to then migrate it! I am closing that above linked PR and will push a new for same (6.5) after this PR merges! |
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This excludes #10568
Just implemented DRY coding a little bit!