Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original dropdown position & alignment and CSS classes #10522

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

SassNinja
Copy link
Contributor

@SassNinja SassNinja commented Aug 7, 2017

I've used the dropdown component to build a custom tooltip.
While working on it I've got two problems:

  1. the original position & alignment gets changed if an overlap is detected but doesn't get restored once the overlap case isn't taking effect anymore
  2. there are no CSS classes set that provide the current position & alignment what is a huge problem if you need to adjust the styling according to the current value (in my case a tooltip arrow whose direction is dependent on the dropdown pane's position)

This PR fixes both of these problems by saving the original values and restoring them before the overlap check. Same for the missing CSS classes that get set & updated every time the position is set.

@kball what do you think about this? Any objections?

@kball
Copy link
Contributor

kball commented Aug 17, 2017

looks good to me

@kball kball merged commit 191ee59 into foundation:develop Aug 17, 2017
@SassNinja SassNinja deleted the feature/dropdown-position branch January 25, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants